Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pdfmake package version #68395

Merged
merged 2 commits into from
Jun 8, 2020

Conversation

jportner
Copy link
Contributor

@jportner jportner commented Jun 5, 2020

Several prior PRs have bumped the pdfmake package's patch version. This package includes quite a bit of transitive dependencies, and many of them have gotten stale.

In this PR, I removed the package and added it again. This ensures that transitive dependencies are updated accordingly.

Additionally, when this packaged was bumped in the past, it was never backported to Kibana's 6.8 branch. I created a separate PR to bump it in that branch.

Companion PR for 6.8: #68396

@jportner jportner added chore v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jun 5, 2020
@jportner jportner requested a review from a team June 5, 2020 17:45
@legrego
Copy link
Member

legrego commented Jun 6, 2020

Ack: will review on Monday

FYI @elastic/kibana-reporting-services we are bumping your dependency for PDF creation. There’s a companion 6.8 PR linked above as well

@legrego legrego self-requested a review June 6, 2020 17:12
@legrego
Copy link
Member

legrego commented Jun 8, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jportner jportner merged commit 77ab709 into elastic:master Jun 8, 2020
@jportner jportner deleted the bump-pdfmake-package-to-0.1.65 branch June 8, 2020 13:19
jportner added a commit to jportner/kibana that referenced this pull request Jun 8, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 8, 2020
* master:
  [ML] DFAnalytics results: ensure ml result fields are shown in data grid (elastic#68305)
  [security_solution] enable react-hooks/exhaustive-deps (elastic#68470)
  Closes elastic#66867 by adding missing, requried API params (elastic#68465)
  [Telemetry] collect number of visualization saved in the past 7, 30 and 90 days (elastic#67865)
  [Logs UI] View in context tweaks (elastic#67777)
  Kibana developer examples landing page (elastic#67049)
  Bump decompress package version (elastic#68386)
  fix elastic#66185 (elastic#66186)
  Bump pdfmake package version (elastic#68395)
  Unskip embeddables/adding_children suite (elastic#68111)
  Add embed mode options in the Share UI (elastic#58435)
  Adding key to avoid react warning (elastic#68491)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported chore release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants