Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Add API tests #70740

Merged
merged 2 commits into from
Jul 7, 2020
Merged

[APM] Add API tests #70740

merged 2 commits into from
Jul 7, 2020

Conversation

sorenlouv
Copy link
Member

Related: #70739

@sorenlouv sorenlouv added Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv requested a review from a team as a code owner July 5, 2020 19:39
@sorenlouv
Copy link
Member Author

retest

@sorenlouv sorenlouv force-pushed the add-api-tests branch 2 times, most recently from 25523a2 to 6b54778 Compare July 6, 2020 12:48
smith
smith approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a few nits but this looks great and works for me.

I like to use this site for guidelines about how to write good tests, even though it's RSpec-specific. Not using "should" makes the output read better: http://www.betterspecs.org/#should

x-pack/test/apm_api_integration/basic/tests/services/top_services.ts Outdated Show resolved Hide resolved
x-pack/test/apm_api_integration/basic/tests/services/top_services.ts Outdated Show resolved Hide resolved
x-pack/test/apm_api_integration/basic/tests/services/top_services.ts
`/api/apm/services?start=${start}&end=${end}&uiFilters=${uiFilters}`
);
// sort services to mitigate unstable sort order
const services = sortBy(response.body.items, ['serviceName']);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a bug in the API that we don't have a stable sort order? No need to change here, but maybe we should open a ticket.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually first fixed it at the source :D

x-pack/test/apm_api_integration/basic/tests/services/transactions/agent_name.ts Outdated Show resolved Hide resolved
x-pack/test/apm_api_integration/basic/tests/services/transactions/agent_name.ts Outdated Show resolved Hide resolved
x-pack/test/apm_api_integration/basic/tests/services/transactions/top_transaction_groups.ts Outdated Show resolved Hide resolved
x-pack/test/apm_api_integration/basic/tests/services/transactions/top_transaction_groups.ts Outdated Show resolved Hide resolved
x-pack/test/apm_api_integration/basic/tests/services/transactions/top_transaction_groups.ts Outdated Show resolved Hide resolved
x-pack/test/apm_api_integration/basic/tests/services/transactions/transaction_charts.ts Outdated Show resolved Hide resolved
x-pack/test/apm_api_integration/basic/tests/services/transactions/transaction_charts.ts Outdated Show resolved Hide resolved
sorenlouv
sorenlouv commented Jul 7, 2020
View reviewed changes
x-pack/plugins/apm/server/routes/settings/agent_configuration.ts
t.partial({ etag: t.string, mark_as_applied_by_agent: t.boolean }),
]);

export type AgentConfigSearchParams = t.TypeOf<typeof searchParamsRt>;
Copy link
Member Author

@sorenlouv sorenlouv Jul 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgieselaar would it be better to have a helper that infers the params from a route? Like:

type AgentConfigSearchParams = RouteParams<typeof agentConfigurationSearchRoute>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, you can possibly extract such a helper from the typings we have today. I'm thinking about making params a io-ts type as well (rather than a record of io-ts types), and then it will be even easier.

@sorenlouv
Copy link
Member Author

retest

@sorenlouv sorenlouv force-pushed the add-api-tests branch 2 times, most recently from 9b8456e to 95d684f Compare July 7, 2020 11:38
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit cb6fbc0 into elastic:master Jul 7, 2020
@sorenlouv sorenlouv deleted the add-api-tests branch July 7, 2020 20:40
@sorenlouv sorenlouv mentioned this pull request Jul 7, 2020
Merged
sorenlouv added a commit to sorenlouv/kibana that referenced this pull request Jul 7, 2020
@sorenlouv
[APM] Add API tests (elastic#70740)
1cc7ae1
sorenlouv added a commit that referenced this pull request Jul 8, 2020
@sorenlouv
[APM] Add API tests (#70740) (#71014)
d15242b
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 8, 2020
@gmmorris
Merge branch 'master' into actions/feature-and-rbac
a84a263 
* master: (36 commits)
  fixed api url in example plugin (elastic#70934)
  [data.search.aggs]: Remove remaining client dependencies (elastic#70251)
  [Security Solution][Endpoint] Fix base64 download bug and adopt new user artifact/manifest format (elastic#70998)
  [Security Solution][Exceptions] - Exception Modal Part I (elastic#70639)
  [SIEM][Detection Engine][Lists] Adds additional data types to value based lists
  [SIEM][Detection Engine][Lists] Removes feature flag for lists
  [APM] Show license callout in ML settings (elastic#70959)
  Migrate service settings test to jest (elastic#70992)
  [APM] Add cloud attributes to data telemetry (elastic#71008)
  Fix breadcrumb on panels for visibility / round corners (elastic#71010)
  Improve search typescript (elastic#69333)
  [savedObjects field count] run in baseline job (elastic#70999)
  [Security Solution] [Timeline] Timeline manager tweaks (elastic#69988)
  [Endpoint] Support redirect from Policy Details to Ingest when user initiates Edit Policy from Datasource Edit page (elastic#70874)
  [APM] Add API tests (elastic#70740)
  [Security Solution][Exceptions] - Tie server and client code together (elastic#70918)
  [Audit Logging] Add AuditTrail service (elastic#69278)
  [Usage Collection] Ensure no type duplicates (elastic#70946)
  [Security Solution] [Timeline] Bugfix for timeline row actions disappear sometimes (elastic#70958)
  [CI] Add pipeline task queue framework and merge workers into one (elastic#64011)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar left review comments

@smith smith smith approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sorenlouv @elasticmachine @kibanamachine @smith @dgieselaar