Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[savedObjects field count] run in baseline job #70999

Merged
merged 1 commit into from
Jul 7, 2020
Merged

[savedObjects field count] run in baseline job #70999

merged 1 commit into from
Jul 7, 2020

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jul 7, 2020 •
edited by rudolf
Loading

We added saved object field count metrics in #70580 but didn't add it to the baseline job, so there are sometimes metrics available from master and sometimes not. This adds the task to the test/scripts/jenkins_xpack_visual_regression.sh script so that it runs against a version of Kibana with xpack included.

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 7, 2020
@spalger spalger marked this pull request as ready for review July 7, 2020 19:04
@spalger spalger requested a review from a team as a code owner July 7, 2020 19:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

brianseeders
brianseeders reviewed Jul 7, 2020
View reviewed changes
test/scripts/jenkins_xpack_visual_regression.sh
@@ -21,3 +21,6 @@ yarn percy exec -t 10000 -- -- \

# cd "$KIBANA_DIR"
# source "test/scripts/jenkins_xpack_page_load_metrics.sh"

cd "$XPACK_DIR"
source "$KIBANA_DIR/test/scripts/jenkins_xpack_saved_objects_field_metrics.sh"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't test/scripts/jenkins_xpack_visual_regression.sh going to be called outside of the baseline job?

If so, jenkins_xpack_saved_objects_field_metrics.sh is run elsewhere, so would run twice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't currently, and we won't be re-enabling the visual regression tests on master/PRs until after I've refactored the baseline job (and a few other blockers are resolved) so I don't think it's a serious issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely crufty though

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 53ee7a7 into elastic:master Jul 7, 2020
@spalger spalger deleted the fix/saved-object-fields-baseline branch July 7, 2020 21:32
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 8, 2020
@gmmorris
Merge branch 'master' into actions/feature-and-rbac
a84a263 
* master: (36 commits)
  fixed api url in example plugin (elastic#70934)
  [data.search.aggs]: Remove remaining client dependencies (elastic#70251)
  [Security Solution][Endpoint] Fix base64 download bug and adopt new user artifact/manifest format (elastic#70998)
  [Security Solution][Exceptions] - Exception Modal Part I (elastic#70639)
  [SIEM][Detection Engine][Lists] Adds additional data types to value based lists
  [SIEM][Detection Engine][Lists] Removes feature flag for lists
  [APM] Show license callout in ML settings (elastic#70959)
  Migrate service settings test to jest (elastic#70992)
  [APM] Add cloud attributes to data telemetry (elastic#71008)
  Fix breadcrumb on panels for visibility / round corners (elastic#71010)
  Improve search typescript (elastic#69333)
  [savedObjects field count] run in baseline job (elastic#70999)
  [Security Solution] [Timeline] Timeline manager tweaks (elastic#69988)
  [Endpoint] Support redirect from Policy Details to Ingest when user initiates Edit Policy from Datasource Edit page (elastic#70874)
  [APM] Add API tests (elastic#70740)
  [Security Solution][Exceptions] - Tie server and client code together (elastic#70918)
  [Audit Logging] Add AuditTrail service (elastic#69278)
  [Usage Collection] Ensure no type duplicates (elastic#70946)
  [Security Solution] [Timeline] Bugfix for timeline row actions disappear sometimes (elastic#70958)
  [CI] Add pipeline task queue framework and merge workers into one (elastic#64011)
  ...
spalger added a commit to spalger/kibana that referenced this pull request Jul 8, 2020
@spalger
Revert "[savedObjects field count] run in baseline job (elastic#70999)"
ee4d442 
This reverts commit 53ee7a7.
spalger added a commit that referenced this pull request Jul 8, 2020
@spalger
Revert #64011 and subsequent fixes (#71137)
b6a06df 
* Revert "temporarily disable firefox functional tests in PRs (#71116)"

This reverts commit 54bd07f.

* Revert "[savedObjects field count] run in baseline job (#70999)"

This reverts commit 53ee7a7.

* Revert "[CI] Add pipeline task queue framework and merge workers into one (#64011)"

This reverts commit 465ed21.

* Revert revert of change to jenkins_xpack_visual_regression.sh

Co-authored-by: spalger <spalger@users.noreply.github.com>
@spalger
Copy link
Contributor Author

spalger commented Jul 8, 2020

Reverted a tiny portion of this that touched the new tasks.groovy file, but the core of this change is still in master.

brianseeders added a commit to brianseeders/kibana that referenced this pull request Jul 9, 2020
@brianseeders
Revert "[savedObjects field count] run in baseline job (elastic#70999)"
370c26b 
This reverts commit 53ee7a7.
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 9, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 70999 or prevent reminders by adding the backport:skip label.

spalger pushed a commit to spalger/kibana that referenced this pull request Jul 9, 2020
@spalger
[savedObjects field count] run in baseline job (elastic#70999)
4518731 
Co-authored-by: spalger <spalger@users.noreply.github.com>
# Conflicts:
#	vars/tasks.groovy
@spalger spalger mentioned this pull request Jul 9, 2020
Merged
spalger added a commit that referenced this pull request Jul 9, 2020
@spalger
fix visual regression job (#70999)
3153dff
spalger added a commit to spalger/kibana that referenced this pull request Jul 9, 2020
@spalger
fix visual regression job (elastic#70999)
bef107f 
(cherry picked from commit 3153dff)
spalger added a commit that referenced this pull request Jul 9, 2020
@spalger
[7.x] [savedObjects field count] run in baseline job (#70999) (#71328)
9ed38ec 
Co-authored-by: spalger <spalger@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 9, 2020
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 10, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into console/fix-a…
b605b6b 
…11y-overlay

* 'master' of github.com:elastic/kibana: (33 commits)
  address index templates feedback (elastic#71353)
  Upgrade EUI to v26.3.1 (elastic#70243)
  [build] Creates Linux aarch64 archive (elastic#69165)
  [SIEM][Detection Engine] Fixes skipped tests (elastic#71347)
  [SIEM][Detection Engine][Lists] Adds read_privileges route for lists and list items
  [kbn/optimizer] implement "requiredBundles" property of KP plugins (elastic#70911)
  [Security Solution][Exceptions] - Exceptions modal pt 2 (elastic#70886)
  [ML] DF Analytics:  stop status polling when job stopped (elastic#71159)
  [SIEM][CASE] IBM Resilient Connector (elastic#66385)
  jenkins_xpack_saved_objects_field_metrics.sh expects to be run from the KIBANA_DIR in CI
  Deduplication of entries and items before sending to endpoint (elastic#71297)
  [services/remote/webdriver] fix eslint error (elastic#71346)
  send slack notifications on visual baseline failures
  fix visual regression job (elastic#70999)
  [Ingest Manager] Add schema to usageCollector. (elastic#71219)
  [ftr] use typed chromeOptions object, adding TEST_BROWSER_BINARY_PATH (elastic#71279)
  [Ingest Manager] Fix limited packages incorrect response (elastic#71292)
  Support multiple features declaring same properties (elastic#71106)
  [Security_Solution][Resolver]Add beta badge to Resolver panel (elastic#71183)
  [DOCS] Clarify trial subscription levels (elastic#70636)
  ...
@jbudz jbudz mentioned this pull request Aug 17, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianseeders brianseeders brianseeders approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spalger @elasticmachine @kibanamachine @brianseeders