[backport] PR #7996 to 4.x - Configurable headers for all elasticsearch requests #8032
+189
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epixa
changed the title
epixa
force-pushed
the
jasper/backport/7996/4.x
branch
from
817c1bb
to
e7bf5de
Compare
--------- **Commit 1:** Configurable headers for all elasticsearch requests A new server-side configuration, elasticsearch.customHeaders, allows people to configure any number of custom headers that will get sent along to all requests to Elasticsearch that are made via the proxy or exposed client. This allows for advanced architectures that do things such as dynamic routing based on install-specific headers. * Original sha: d00d177 * Authored by Court Ewing <court@epixa.com> on 2016-08-13T16:46:54Z
epixa
force-pushed
the
jasper/backport/7996/4.x
branch
from
e7bf5de
to
8b17749
Compare
|
@spalger @BigFunger Can you guys take a look at this backport of the custom es header config? It required a good deal of wrangling to get it into 4.x. |
|
Code LGTM. Testing functionality... |
|
Tested functionality using Wireshark. LGTM:
LGTM overall. |
|
Thanks! |
This was referenced Aug 25, 2016
| @@ -11,6 +14,7 @@ module.exports = function mapUri(server, prefix) { | |||
| } | |||
| const query = querystring.stringify(request.query); | |||
| if (query) url += '?' + query; | |||
| done(null, url); | |||
| const customHeaders = setHeaders(request.headers, config.get('elasticsearch.customHeaders')); | |||
There was a problem hiding this comment.
What will happen to the host header here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #7996
Commit 1:
Configurable headers for all elasticsearch requests
A new server-side configuration, elasticsearch.customHeaders, allows
people to configure any number of custom headers that will get sent
along to all requests to Elasticsearch that are made via the proxy or
exposed client.
This allows for advanced architectures that do things such as dynamic
routing based on install-specific headers.