Under most of the customHeaders configuration #8095
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a bug with the elasticsearch customHeader configuration logic in the hapi proxy that causes issues when elasticsearch is behind ssl but Kibana is not, which is a common situation when there's a reverse proxy in front of Kibana that is doing ssl termination. Rather than revert all of the changes in that entire commit, this simply undoes the custom header logic to the proxy itself and removes the public documentation for it since the feature isn't particularly useful in this form.
|
I'm still not sold that this is the right move for 4.6.0, but I wanted to have it ready. |
|
We fixed this properly, so this is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug with the elasticsearch customHeader configuration logic in
the hapi proxy that causes issues when elasticsearch is behind ssl but
Kibana is not, which is a common situation when there's a reverse proxy
in front of Kibana that is doing ssl termination.
Rather than revert all of the changes in that entire commit, this simply
undoes the custom header logic to the proxy itself and removes the
public documentation for it since the feature isn't particularly useful
in this form.
The original configurable header backport PR is #8032
Fixes #8093