-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[App Search] Credentials: add FlashMessages, stub out credentials flyout #81391
Conversation
+ split out child sub components for easier testing/reading
- mostly just DELETE_MESSAGE currently, since that's what's already wired up - CREATE_MESSAGE and UPDATE_MESSAGE will be used in an upcoming commit + adds FlashMessages in flyout, which will show returned form errors from the API
e.g. deletion success messages + incidental linting/cleanup
@JasonStoltz highlighting 8211f17 - I'm going to be splitting a ton of the flyout/form into sub-components as part of my PRs because I strongly think it makes the code easier to read and easier to write tests for (vs a single massive test file). In particular IMO, this definitely pays off when unit testing individual form components (see PR 3). Let me know what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@@ -24,16 +24,19 @@ import { | |||
import { i18n } from '@kbn/i18n'; | |||
|
|||
import { SetAppSearchChrome as SetPageChrome } from '../../../shared/kibana_chrome'; | |||
import { FlashMessages } from '../../../shared/flash_messages'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, guess we missed these previously.
…out (#81391) (#81517) * Added an empty Flyout * Refactor CredentialsFlyout to its own component folder + split out child sub components for easier testing/reading * Add initial FlashMessages setup - mostly just DELETE_MESSAGE currently, since that's what's already wired up - CREATE_MESSAGE and UPDATE_MESSAGE will be used in an upcoming commit + adds FlashMessages in flyout, which will show returned form errors from the API * Fix flash messages appearing on flyout open e.g. deletion success messages + incidental linting/cleanup Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com> Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
History
To update your PR or re-run it, just comment with: |
PR sequence
This PR is part of a set of 3 PRs that implements the Credentials flyout form + functionality. I broke it up into PRs in the 400-800 line range so as not to open a 1700~ line PR 😬
List of all PRs (may be helpful for obtaining more context / QAing the entire final feature)
Summary
This PR achieves:
Screencaps
QA
Checklist