Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App Search] Credentials: add FlashMessages, stub out credentials flyout #81391

Merged
merged 4 commits into from
Oct 22, 2020
Merged

[App Search] Credentials: add FlashMessages, stub out credentials flyout #81391

merged 4 commits into from
Oct 22, 2020

Commits on Oct 21, 2020

  1. Added an empty Flyout

    @JasonStoltz @cee-chen
    JasonStoltz authored and cee-chen committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    8988d49 View commit details
    Browse the repository at this point in the history

  2. Refactor CredentialsFlyout to its own component folder 

    + split out child sub components for easier testing/reading
    @cee-chen
    cee-chen committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    8211f17 View commit details
    Browse the repository at this point in the history

  3. Add initial FlashMessages setup 

    - mostly just DELETE_MESSAGE currently, since that's what's already wired up
- CREATE_MESSAGE and UPDATE_MESSAGE will be used in an upcoming commit

+ adds FlashMessages in flyout, which will show returned form errors from the API
    @cee-chen
    cee-chen committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    8688740 View commit details
    Browse the repository at this point in the history

  4. Fix flash messages appearing on flyout open 

    e.g. deletion success messages

+ incidental linting/cleanup
    @cee-chen
    cee-chen committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    dcac3c6 View commit details
    Browse the repository at this point in the history