Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTSR] Convert to tasks and add jest/api integration suites #91770

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

brianseeders
Copy link
Contributor

@brianseeders brianseeders commented Feb 17, 2021

I originally set out to add the integration test suites to the FTSR. Some of the integration tests require a unique workspace because they write to files in the kibana directory, so I converted FTSR to use the tasks framework, since that provides unique workspaces for parallel tasks.

Some example runs:
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1315/
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1316/
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1313/
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1314/

The integration suites will require changes to the Jenkins job definition in a separate repo.

@brianseeders brianseeders added Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.12.0 v7.11.1 Team:Operations Team label for Operations Team labels Feb 17, 2021
@brianseeders brianseeders changed the title Flaky Test Suite Runner - Convert to tasks and add jest/api integration suites [FTSR] Convert to tasks and add jest/api integration suites Feb 17, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@brianseeders brianseeders marked this pull request as ready for review February 18, 2021 18:41
@brianseeders brianseeders requested a review from a team as a code owner February 18, 2021 18:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@brianseeders brianseeders enabled auto-merge (squash) February 18, 2021 19:20
Comment on lines +76 to +80
if (!config.isXpack) {
kibanaPipeline.buildOss()
} else {
kibanaPipeline.buildXpack()
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: not with an else is a little harder to follow.

@brianseeders brianseeders merged commit a82b13d into elastic:master Feb 18, 2021
@brianseeders brianseeders added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 18, 2021
@brianseeders brianseeders deleted the ftsr-add-integration branch February 18, 2021 19:56
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 18, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 18, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

❌ 7.11: Commit could not be cherrypicked due to conflicts
7.12 / #91927
7.x / #91928

Successful backport PRs will be merged automatically after passing CI.

To backport manually, check out the target branch and run:
node scripts/backport --pr 91770

brianseeders added a commit to brianseeders/kibana that referenced this pull request Feb 18, 2021
kibanamachine added a commit that referenced this pull request Feb 18, 2021
…91928)

Co-authored-by: Brian Seeders <brian.seeders@elastic.co>
kibanamachine added a commit that referenced this pull request Feb 18, 2021
…91927)

Co-authored-by: Brian Seeders <brian.seeders@elastic.co>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 19, 2021
* master: (111 commits)
  [Logs UI] Replace dependencies in the infra bundle (elastic#91503)
  [Search Source] Do not request unmapped fields if source filters are provided (elastic#91921)
  [APM] Kql Search Bar suggests values outside the selected time range (elastic#91918)
  Refactored component edit policy tests into separate folders and using client integration testing setup (elastic#91657)
  [Fleet] Don't error on missing package_assets value (elastic#91744)
  [Lens] Pass used histogram interval to chart (elastic#91370)
  [Indexpattern management] Use indexPatterns Service instead of savedObjects client (elastic#91839)
  [Security Solutions] Fixes Cypress tests for indicator match by making the selectors more specific (elastic#91947)
  [CI] backportrc can skip CI (elastic#91886)
  Revert "[SOM] fix flaky suites (elastic#91809)"
  [Fleet] Install Elastic Agent integration by default during setup (elastic#91676)
  [Fleet] Silently swallow 404 errors when deleting ingest pipelines (elastic#91778)
  [data.search] Use incrementCounter for search telemetry (elastic#91230)
  [Fleet] Bootstrap functional test suite (elastic#91898)
  [Alerts][Docs] Added API documentation for alerts plugin (elastic#91067)
  Use correct environment in anomaly detection setup link (elastic#91877)
  [FTSR] Convert to tasks and add jest/api integration suites (elastic#91770)
  [CI] Build and publish storybooks (elastic#87701)
  docs: add PHP agent info to docs (elastic#91773)
  [DOCS] Adds and updates Visualization advanced settings (elastic#91904)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.11.1 v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants