Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct environment in anomaly detection setup link #91877

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

smith
Copy link
Contributor

@smith smith commented Feb 18, 2021

This was still using uiFilters.environment instead of environment, so the warning would never show.

This was still using `uiFilters.environment` instead of environment, so the warning would never show.
@smith smith added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Feb 18, 2021
@smith smith requested a review from a team as a code owner February 18, 2021 16:33
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Feb 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.2MB 5.2MB -24.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 863a2d0 into elastic:master Feb 18, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 18, 2021
This was still using `uiFilters.environment` instead of environment, so the warning would never show.
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.12 / #91930

Successful backport PRs will be merged automatically after passing CI.

@smith smith deleted the nls/env-setup branch February 18, 2021 20:34
kibanamachine added a commit that referenced this pull request Feb 18, 2021
)

This was still using `uiFilters.environment` instead of environment, so the warning would never show.

Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 19, 2021
* master: (111 commits)
  [Logs UI] Replace dependencies in the infra bundle (elastic#91503)
  [Search Source] Do not request unmapped fields if source filters are provided (elastic#91921)
  [APM] Kql Search Bar suggests values outside the selected time range (elastic#91918)
  Refactored component edit policy tests into separate folders and using client integration testing setup (elastic#91657)
  [Fleet] Don't error on missing package_assets value (elastic#91744)
  [Lens] Pass used histogram interval to chart (elastic#91370)
  [Indexpattern management] Use indexPatterns Service instead of savedObjects client (elastic#91839)
  [Security Solutions] Fixes Cypress tests for indicator match by making the selectors more specific (elastic#91947)
  [CI] backportrc can skip CI (elastic#91886)
  Revert "[SOM] fix flaky suites (elastic#91809)"
  [Fleet] Install Elastic Agent integration by default during setup (elastic#91676)
  [Fleet] Silently swallow 404 errors when deleting ingest pipelines (elastic#91778)
  [data.search] Use incrementCounter for search telemetry (elastic#91230)
  [Fleet] Bootstrap functional test suite (elastic#91898)
  [Alerts][Docs] Added API documentation for alerts plugin (elastic#91067)
  Use correct environment in anomaly detection setup link (elastic#91877)
  [FTSR] Convert to tasks and add jest/api integration suites (elastic#91770)
  [CI] Build and publish storybooks (elastic#87701)
  docs: add PHP agent info to docs (elastic#91773)
  [DOCS] Adds and updates Visualization advanced settings (elastic#91904)
  ...
smith added a commit to smith/kibana that referenced this pull request Mar 2, 2021
This was still using `uiFilters.environment` instead of environment, so the warning would never show.
smith added a commit that referenced this pull request Mar 2, 2021
)

This was still using `uiFilters.environment` instead of environment, so the warning would never show.
@ogupte ogupte self-assigned this Mar 3, 2021
@ogupte ogupte added the apm:test-plan-done Pull request that was successfully tested during the test plan label Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:test-plan-7.12.0 apm:test-plan-done Pull request that was successfully tested during the test plan auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants