Discover: Add handling for source column #91815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Feature:Discover
majagrubic
approved these changes
Feb 18, 2021
| ...state, | ||
| columns: state.columns.filter((column) => column !== '_source'), | ||
| }; | ||
| } else if (state.columns.length === 0) { |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
majagrubic
approved these changes
Feb 18, 2021
31 tasks
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Feb 19, 2021
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Feb 19, 2021
flash1293
added a commit
that referenced
this pull request
Feb 19, 2021
* Discover: Add handling for source column (#91815) * enable by default * [Discover] Fix context view for date_nanos format with custom timestamps (#54089) * Switch from _source to fields when fetching anchor records with date_nanos timestamps * Add testdata * Add functional test * fix search_after Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
flash1293
added a commit
that referenced
this pull request
Feb 19, 2021
* Discover: Add handling for source column (#91815) * enable by default * fix conflicts * fix search_after * fix test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91493
Fixes #91633
Makes sure the column list is always in sync with the current state of fields vs source fetching (removing the source column if it is present)