EsArchiver: support for injecting kibana version and use it for spaces tests #94420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing up spaces tests
rudolf
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
rudolf
added
the
release_note:skip
legrego
approved these changes
Mar 11, 2021
spalger
reviewed
Mar 11, 2021
pgayvallet
approved these changes
Mar 14, 2021
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
9 tasks
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
Mar 21, 2021
…s tests (elastic#94420) * EsArchiver: support for injecting kibana version and use it for speeding up spaces tests * Use kbn/utils to get current kibana version in tests * Review feedback: improve test by splitting variable over chunks # Conflicts: # x-pack/test/functional/es_archives/saved_objects_management/spaces_integration/mappings.json # x-pack/test/saved_object_api_integration/common/fixtures/es_archiver/saved_objects/spaces/mappings.json # x-pack/test/spaces_api_integration/common/fixtures/es_archiver/saved_objects/spaces/mappings.json
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
Mar 21, 2021
…s tests (elastic#94420) * EsArchiver: support for injecting kibana version and use it for speeding up spaces tests * Use kbn/utils to get current kibana version in tests * Review feedback: improve test by splitting variable over chunks # Conflicts: # x-pack/test/functional/es_archives/saved_objects_management/spaces_integration/mappings.json # x-pack/test/saved_object_api_integration/common/fixtures/es_archiver/saved_objects/spaces/mappings.json # x-pack/test/spaces_api_integration/common/fixtures/es_archiver/saved_objects/spaces/mappings.json
rudolf
added a commit
that referenced
this pull request
Mar 22, 2021
…s tests (#94420) (#95031) * EsArchiver: support for injecting kibana version and use it for speeding up spaces tests * Use kbn/utils to get current kibana version in tests * Review feedback: improve test by splitting variable over chunks # Conflicts: # x-pack/test/functional/es_archives/saved_objects_management/spaces_integration/mappings.json # x-pack/test/saved_object_api_integration/common/fixtures/es_archiver/saved_objects/spaces/mappings.json # x-pack/test/spaces_api_integration/common/fixtures/es_archiver/saved_objects/spaces/mappings.json
kibanamachine
removed
the
backport missing
rudolf
added a commit
that referenced
this pull request
Mar 22, 2021
…s tests (#94420) (#95030) * EsArchiver: support for injecting kibana version and use it for speeding up spaces tests * Use kbn/utils to get current kibana version in tests * Review feedback: improve test by splitting variable over chunks # Conflicts: # x-pack/test/functional/es_archives/saved_objects_management/spaces_integration/mappings.json # x-pack/test/saved_object_api_integration/common/fixtures/es_archiver/saved_objects/spaces/mappings.json # x-pack/test/spaces_api_integration/common/fixtures/es_archiver/saved_objects/spaces/mappings.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #91829 we changed the spaces esarchiver fixtures so that v2 migrations would have to do less work thereby speeding up the spaces tests. However, v2 migrations use the kibana version in the index name and in that PR we hardcoded this value making it hard to maintain as we bump Kibana version numbers on 7.x.
This PR adds a special
$KIBANA_PACKAGE_VERSIONvariable to esarchiver archives that will be replaced by the Kibana version from thepackage.json. This way we can speed up tests and backport it to 7.x without causing issues when bumping Kibana's version.Checklist
Delete any items that are not applicable to this PR.
For maintainers