-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Update text in Fleet Settings flyout / confirm modals #97648
Conversation
Pinging @elastic/fleet (Team:Fleet) |
Pinging @elastic/fleet (Feature:Fleet) |
Pinging @elastic/kibana-docs (Team:Docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text LGTM, with one minor comment.
x-pack/plugins/fleet/public/applications/fleet/components/settings_flyout/confirm_modal.tsx
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @afgomez |
…c#97648) * Remove "Global Output" heading from the flyout * Tweak flyout description * Tweak fleet server hosts input description * Tweak ES hosts input description * Tweak modal button * Tweak confirmation modal callout title * Tweak callout when fleet server hosts are modified * Tweak callout when ES hosts are modified * Fix i18n * Remove period from title
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
#97715) * Remove "Global Output" heading from the flyout * Tweak flyout description * Tweak fleet server hosts input description * Tweak ES hosts input description * Tweak modal button * Tweak confirmation modal callout title * Tweak callout when fleet server hosts are modified * Tweak callout when ES hosts are modified * Fix i18n * Remove period from title Co-authored-by: Alejandro Fernández Gómez <alejandro.fernandez@elastic.co>
…c#97648) * Remove "Global Output" heading from the flyout * Tweak flyout description * Tweak fleet server hosts input description * Tweak ES hosts input description * Tweak modal button * Tweak confirmation modal callout title * Tweak callout when fleet server hosts are modified * Tweak callout when ES hosts are modified * Fix i18n * Remove period from title
#97930) * Remove "Global Output" heading from the flyout * Tweak flyout description * Tweak fleet server hosts input description * Tweak ES hosts input description * Tweak modal button * Tweak confirmation modal callout title * Tweak callout when fleet server hosts are modified * Tweak callout when ES hosts are modified * Fix i18n * Remove period from title Co-authored-by: Alejandro Fernández Gómez <alejandro.fernandez@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…c#97648) * Remove "Global Output" heading from the flyout * Tweak flyout description * Tweak fleet server hosts input description * Tweak ES hosts input description * Tweak modal button * Tweak confirmation modal callout title * Tweak callout when fleet server hosts are modified * Tweak callout when ES hosts are modified * Fix i18n * Remove period from title
Summary
Closes #96161. Tweaks the copy for the Fleet settings flyout and the settings confirmation modal.
Flyout:
Modal: