Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Update text in Fleet Settings flyout / confirm modals #97648

Merged
merged 10 commits into from
Apr 20, 2021

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Apr 20, 2021

Summary

Closes #96161. Tweaks the copy for the Fleet settings flyout and the settings confirmation modal.

Flyout:
Screenshot 2021-04-20 at 17 05 47

Modal:
Screenshot 2021-04-20 at 17 05 53

@afgomez afgomez added release_note:skip Skip the PR/issue when compiling release notes Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team v7.13.0 labels Apr 20, 2021
@afgomez afgomez requested a review from a team as a code owner April 20, 2021 14:47
@afgomez afgomez self-assigned this Apr 20, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Feature:Fleet)

@afgomez afgomez added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 20, 2021
@afgomez afgomez requested a review from a team April 20, 2021 14:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text LGTM, with one minor comment.

Alejandro Fernández Gómez added 2 commits April 20, 2021 17:35
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 787.1KB 786.5KB -640.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @afgomez

@jen-huang jen-huang merged commit f374920 into elastic:master Apr 20, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 20, 2021
…c#97648)

* Remove "Global Output" heading from the flyout

* Tweak flyout description

* Tweak fleet server hosts input description

* Tweak ES hosts input description

* Tweak modal button

* Tweak confirmation modal callout title

* Tweak callout when fleet server hosts are modified

* Tweak callout when ES hosts are modified

* Fix i18n

* Remove period from title
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 21, 2021
#97715)

* Remove "Global Output" heading from the flyout

* Tweak flyout description

* Tweak fleet server hosts input description

* Tweak ES hosts input description

* Tweak modal button

* Tweak confirmation modal callout title

* Tweak callout when fleet server hosts are modified

* Tweak callout when ES hosts are modified

* Fix i18n

* Remove period from title

Co-authored-by: Alejandro Fernández Gómez <alejandro.fernandez@elastic.co>
spalger pushed a commit to spalger/kibana that referenced this pull request Apr 21, 2021
…c#97648)

* Remove "Global Output" heading from the flyout

* Tweak flyout description

* Tweak fleet server hosts input description

* Tweak ES hosts input description

* Tweak modal button

* Tweak confirmation modal callout title

* Tweak callout when fleet server hosts are modified

* Tweak callout when ES hosts are modified

* Fix i18n

* Remove period from title
spalger pushed a commit that referenced this pull request Apr 22, 2021
#97930)

* Remove "Global Output" heading from the flyout

* Tweak flyout description

* Tweak fleet server hosts input description

* Tweak ES hosts input description

* Tweak modal button

* Tweak confirmation modal callout title

* Tweak callout when fleet server hosts are modified

* Tweak callout when ES hosts are modified

* Fix i18n

* Remove period from title

Co-authored-by: Alejandro Fernández Gómez <alejandro.fernandez@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
madirey pushed a commit to madirey/kibana that referenced this pull request May 11, 2021
…c#97648)

* Remove "Global Output" heading from the flyout

* Tweak flyout description

* Tweak fleet server hosts input description

* Tweak ES hosts input description

* Tweak modal button

* Tweak confirmation modal callout title

* Tweak callout when fleet server hosts are modified

* Tweak callout when ES hosts are modified

* Fix i18n

* Remove period from title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Fleet Fleet team's agent central management project release_note:skip Skip the PR/issue when compiling release notes Team:Docs Team:Fleet Team label for Observability Data Collection Fleet team v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Update text in Fleet Settings flyout / confirm modals
6 participants