[Upgrade Assistant] Address copy feedback #99632
Conversation
alisonelizabeth
added
v8.0.0
Team:Kibana Management
| @@ -13,15 +13,9 @@ import { i18n } from '@kbn/i18n'; | |||
| import { LevelFilterOption } from '../../types'; | |||
|
|
|||
| const LocalizedOptions: { [option: string]: string } = { | |||
| warning: i18n.translate( | |||
There was a problem hiding this comment.
this is not being used anymore
| @@ -14,10 +14,10 @@ import { GroupByOption } from '../../types'; | |||
|
|
|||
| const LocalizedOptions: { [option: string]: string } = { | |||
| message: i18n.translate('xpack.upgradeAssistant.checkupTab.controls.groupByBar.byIssueLabel', { | |||
| defaultMessage: 'by issue', | |||
| defaultMessage: 'By issue', | |||
There was a problem hiding this comment.
@debadair since you suggested capitalizing Critical and Warning, it seemed like we should also capitalize the By issue and By index filters on the ES deprecations page. Let me know if you disagree.
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
There was a problem hiding this comment.
These changes LGTM.
I'm assuming the steps to resolve are placeholder text, but a couple things to note for future reference:
- Use bold instead of quotes for emphasis when directing the user to interact with a UI element.
- We generally use "Go to xyz" instead of "Navigate to".
In the Elasticsearch section, I think I'd explicitly recommend backing up your data before making changes. IOW, add "Back up your data before making changes to your Elasticsearch configuration." As it is, the back up button just feels sort of stuck there.
Similar to the Kibana issues list, it would be good if the Elasticsearch issues could specify the affected index.
|
Thanks @debadair for the review!
This text is provided by the plugin owner responsible for registering the deprecation. I'll make a note of this and reach out the timelion team about updating it.
👍 thanks for the feedback. I think it was originally text w/ a link (for the 6-7 upgrade), and we moved toward the button only as part of the redesign. /cc @dborodyansky
I'm not sure I follow this comment. Are you referring to the including the index name as part of the description? If so, Dmitry is working on some changes to the layout and I think this concern will be addressed. |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
…deprecation-ilm-policy * 'master' of github.com:elastic/kibana: (101 commits) [ftr] migrate "docTable" service to FtrService class (elastic#100595) [ftr] migrate "listingTable" service to FtrService class (elastic#100606) Fixed comparing real value with formatted according to mode. (elastic#100456) [ftr] migrate "dataGrid" service to FtrService class (elastic#100593) [ftr] migrate "fieldEditor" to FtrService class (elastic#100597) [ftr] migrate "filterBar" service to FtrService class (elastic#100601) [triggersActionsUi] Reduce page load bundle to under 100kB (elastic#97770) [build] Clean jest configs (elastic#100594) refact(NA): remove extra pkg_npm target and add specific target folders for @kbn/analytics on Bazel (elastic#100569) Update dependency @elastic/charts to v29.2.0 (elastic#100587) [Maps] convert LayerPanel to typescript (elastic#100481) [Upgrade Assistant] Address copy feedback (elastic#99632) Open/Closed filter for observability alerts page (elastic#99217) One liner to expose the EQL query for debugging for users (elastic#100565) [KibanaPageLayout] Solution Nav specific styles & props (elastic#100089) [ftr] implement FtrService classes and migrate common services (elastic#99546) [XY] [Lens] Adds opacity slider (elastic#100453) [Reporting] ILM policy for managing reporting indices (elastic#100130) [Reporting] ILM policy for managing reporting indices (elastic#100130) [DOCS] Remove redundant maps attribute (elastic#100426) ... # Conflicts: # x-pack/plugins/reporting/server/lib/store/report_ilm_policy.ts # x-pack/plugins/reporting/server/lib/store/store.test.ts # x-pack/plugins/reporting/server/lib/store/store.ts
This PR addresses copy feedback in #97159.