-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Upgrade Assistant] Address copy feedback #99632
Merged
alisonelizabeth
merged 8 commits into
elastic:master
from
alisonelizabeth:ua/copy-fixes
May 25, 2021
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
41fa8b2
address copy feedback
alisonelizabeth 6490fbe
update i18n
alisonelizabeth 4396fdb
remove unused import
alisonelizabeth 624fbbf
update tests
alisonelizabeth 0c8e074
Merge branch 'master' into ua/copy-fixes
kibanamachine 15cd468
Merge branch 'master' into ua/copy-fixes
kibanamachine 62f75ca
Merge branch 'master' of https://github.com/elastic/kibana into ua/co…
alisonelizabeth b212a10
Merge branch 'master' into ua/copy-fixes
kibanamachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,15 +13,9 @@ import { i18n } from '@kbn/i18n'; | |
import { LevelFilterOption } from '../../types'; | ||
|
||
const LocalizedOptions: { [option: string]: string } = { | ||
warning: i18n.translate( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is not being used anymore |
||
'xpack.upgradeAssistant.checkupTab.controls.filterBar.warningButtonLabel', | ||
{ | ||
defaultMessage: 'warning', | ||
} | ||
), | ||
critical: i18n.translate( | ||
'xpack.upgradeAssistant.checkupTab.controls.filterBar.criticalButtonLabel', | ||
{ defaultMessage: 'critical' } | ||
{ defaultMessage: 'Critical' } | ||
), | ||
}; | ||
interface DeprecationLevelProps { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@debadair since you suggested capitalizing
Critical
andWarning
, it seemed like we should also capitalize theBy issue
andBy index
filters on the ES deprecations page. Let me know if you disagree.