Generate the Semantic Colours as class members in Swift. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move core colours into their own class but leaving them as static.
pixlwave
commented
Jul 9, 2024
| import: ["SwiftUI"], | ||
| objectType: "class", | ||
| accessControl: "public", | ||
| referenceClass: "CompoundCoreColorTokens" |
There was a problem hiding this comment.
This is somewhat of a hack…
pixlwave
commented
Jul 9, 2024
| }).join('\n') | ||
| %> | ||
|
|
||
| <%= options.accessControl %> <%= options.objectType %> <%= file.className %> { | ||
| <%= allProperties.map(function(prop) { | ||
| return options.accessControl + ' let ' + formatProperty(prop); | ||
| let formatted = formatProperty(prop); | ||
| if (options.referenceClass) { |
There was a problem hiding this comment.
… but it works well enough to access the references from the correct class.
pixlwave
commented
Jul 9, 2024
Comment on lines
+318
to
+319
| public static let bgSubtleSecondaryLevel0 = themeBg | ||
| public static let bgCanvasDefaultLevel1 = gray300 |
There was a problem hiding this comment.
These 2 aren't used in the app as they're asymmetric and we still need to figure out how to generate them correctly.
robintown
approved these changes
Jul 9, 2024
Co-authored-by: Robin <robin@robin.town>
Co-authored-by: Robin <robin@robin.town>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR makes 2 changes to the Swift colour token generation (and can be reviewed commit-by-commit):
colorprefix from the colour tokens given they're all namespaced anyway.