Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for customising specific colours. #94

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jul 9, 2024

Can be reviewed commit-by-commit, this PR adopts the new token format for semantic tokens and uses these to allow runtime customisation of the colours. Some beautiful examples of this working:

Simulator Screenshot - iPhone 15 Pro - 2024-07-09 at 16 18 37 Simulator Screenshot - iPhone 15 Pro - 2024-07-09 at 16 18 59

@pixlwave pixlwave requested a review from a team as a code owner July 9, 2024 16:05
@pixlwave pixlwave requested review from Velin92 and removed request for a team July 9, 2024 16:05
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.43%. Comparing base (a56eca3) to head (3b41aea).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   96.73%   96.43%   -0.31%     
==========================================
  Files          18       18              
  Lines        1255     1149     -106     
==========================================
- Hits         1214     1108     -106     
  Misses         41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit ac768a4 into main Jul 9, 2024
2 checks passed
@pixlwave pixlwave deleted the doug/colour-tokens branch July 9, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants