Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safe Area Inset Issues #3067

Closed
ismailgulek opened this issue Apr 7, 2020 · 0 comments · Fixed by #3084
Closed

Safe Area Inset Issues #3067

ismailgulek opened this issue Apr 7, 2020 · 0 comments · Fixed by #3084
Assignees
@ismailgulek
Milestone
Sprint 27: iOS13 ...

Comments

@ismailgulek
Copy link
Contributor

ismailgulek commented Apr 7, 2020 •
edited
Loading

Safe area insets are not considered on some screens, like image/avatar upload preview, VoIP/Jitsi call, return to call button.

Sample:
4
@ismailgulek ismailgulek self-assigned this Apr 7, 2020
@ismailgulek ismailgulek mentioned this issue Apr 8, 2020
Closed
ismailgulek added a commit to matrix-org/matrix-ios-kit that referenced this issue Apr 9, 2020
@ismailgulek
Update CHANGES.rst, changes for element-hq/element-ios#3067
fd67421 
Signed-off-by: ismailgulek <gulekismail@gmail.com>
ismailgulek added a commit that referenced this issue Apr 9, 2020
@ismailgulek
Update CHANGES.rest, fixes #3067
87d6d3a 
Signed-off-by: ismailgulek <gulekismail@gmail.com>
@ismailgulek ismailgulek linked a pull request Apr 9, 2020 that will close this issue
Consider Safe Area Insets for Some Screens #3084
Merged
ismailgulek added a commit to matrix-org/matrix-ios-kit that referenced this issue Apr 10, 2020
@ismailgulek
Replace deprecated MPMoviePlayerController with AVPlayerViewController,
8d2e855 
fixes #645, changes for element-hq/element-ios#3081, element-hq/element-ios#3067

Signed-off-by: ismailgulek <gulekismail@gmail.com>
ismailgulek added a commit to matrix-org/matrix-ios-kit that referenced this issue Apr 21, 2020
@ismailgulek
MXKAttachmentsViewController navigation bar respect to safe area, for e…
173dd6e 
…lement-hq/element-ios#3067

Signed-off-by: ismailgulek <gulekismail@gmail.com>
@ismailgulek ismailgulek mentioned this issue Apr 21, 2020
Merged
ismailgulek added a commit that referenced this issue Apr 22, 2020
@ismailgulek
Update CHANGES.rest, fixes #3067
5615463 
Signed-off-by: ismailgulek <gulekismail@gmail.com>
ismailgulek added a commit to matrix-org/matrix-ios-kit that referenced this issue Apr 22, 2020
@ismailgulek
Remove bottomLayoutGuide and content view equal width constraints, for …
c6bb32e 
…element-hq/element-ios#3067

Signed-off-by: ismailgulek <gulekismail@gmail.com>
@ismailgulek ismailgulek mentioned this issue Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ismailgulek ismailgulek

Labels
None yet
Projects
None yet
Milestone
Sprint 27: iOS13 Maintenance
Development

Successfully merging a pull request may close this issue.

Consider Safe Area Insets for Some Screens element-hq/element-ios
1 participant
@ismailgulek