Consider Safe Area Insets for Some Screens #3084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| import Foundation | ||
| import UIKit | ||
|
|
||
| @objc extension UIDevice { |
There was a problem hiding this comment.
I think we can manage safe area without this code atm. It could be dangerous to use magic numbers as those values could change for an iOS version or an iOS device.
Comment on lines
+4246
to
+4250
| if (UIDevice.currentDevice.hasNotch) | ||
| { | ||
| // this device has a notch (iPhone X +) | ||
| result += UIApplication.sharedApplication.keyWindow.safeAreaInsets.top; | ||
| } |
There was a problem hiding this comment.
Instead of using hasNotch we could use this:
static CGFloat kCallStatusBarSafeAreaExtraHeight = 24;
result = MAX(UIApplication.sharedApplication.keyWindow.safeAreaInsets.top + kCallStatusBarSafeAreaExtraHeight, CALL_STATUS_BAR_HEIGHT);
Riot/AppDelegate.m
Outdated
Comment on lines
4269
to
4275
| if (@available(iOS 11.0, *)) | ||
| { | ||
| UIEdgeInsets safeAreaInsets = UIApplication.sharedApplication.keyWindow.safeAreaInsets; | ||
| safeAreaInsets.top = topBarSize.height - CALL_STATUS_BAR_HEIGHT; | ||
| safeAreaInsets.bottom = 0.0; | ||
| _callStatusBarButton.titleEdgeInsets = safeAreaInsets; | ||
| } |
There was a problem hiding this comment.
We can move this behavior to statusBarDidChangeFrame method.
| break; | ||
| } | ||
| default: | ||
| { | ||
| _callStatusBarWindow.transform = CGAffineTransformIdentity; | ||
| _callStatusBarWindow.frame = CGRectMake(0, 0, rootControllerFrame.size.width, CALL_STATUS_BAR_HEIGHT); | ||
| _callStatusBarWindow.frame = CGRectMake(0, 0, rootControllerFrame.size.width, callStatusBarHeight); |
There was a problem hiding this comment.
Above if (_callStatusBarWindow) we can add:
UIEdgeInsets callBarButtonContentEdgeInsets = UIEdgeInsetsZero;
and here we can add:
if (@available(iOS 11.0, *))
{
callBarButtonContentEdgeInsets.top = callStatusBarHeight - CALL_STATUS_BAR_HEIGHT;
}
There was a problem hiding this comment.
Done with some changes.
This was
linked to
issues
Apr 10, 2020
ismailgulek
force-pushed
the
riot_3067
branch
2 times, most recently
from
8f5e1cb
to
8533fd5
Compare
ismailgulek
added a commit
that referenced
this pull request
Apr 13, 2020
…for #3084 Signed-off-by: ismailgulek <gulekismail@gmail.com>
|
General comments for devices with a notch:
Here some regressions for left/right safe area in landascape:
Here some regressions about home indicator underlap:
|
Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
…for #3084 Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
…a view with translucent bar Signed-off-by: ismailgulek <gulekismail@gmail.com>
…cognizer, do not destroy child pages until navigation completed Signed-off-by: ismailgulek <gulekismail@gmail.com>
…translucent Signed-off-by: ismailgulek <gulekismail@gmail.com>
…home indicator Signed-off-by: ismailgulek <gulekismail@gmail.com>
…dicator Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
… bug fix Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
…home indicator Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
Signed-off-by: ismailgulek <gulekismail@gmail.com>
SBiOSoftWhare
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.