Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the SDK retrieve and parse Element well known content #3127

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jul 2, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Configure Element Call's widget URL using the new SDK APIs that perform HTTP request and parses the element.json wellknown

FTR iOS PR is element-hq/element-x-ios#2971

Motivation and context

Closes #3124

Screenshots / GIFs

Tests

  • Not tested with a server having custom configuration, but this should not break doing a call using matrix.org for instance.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner July 2, 2024 11:34
@bmarty bmarty requested review from ganfra and removed request for a team July 2, 2024 11:34
Copy link
Contributor

github-actions bot commented Jul 2, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/tPqUcp

@bmarty bmarty changed the title Feature/bma/element well known Let the SDK retrieve and parse Element well known content Jul 2, 2024
@bmarty bmarty added the PR-Change For updates to an existing feature label Jul 2, 2024
Copy link

sonarcloud bot commented Jul 2, 2024

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.00%. Comparing base (b46f47f) to head (3135c53).
Report is 5 commits behind head on develop.

Files Patch % Lines
.../android/libraries/matrix/test/FakeMatrixClient.kt 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3127      +/-   ##
===========================================
+ Coverage    75.96%   76.00%   +0.04%     
===========================================
  Files         1638     1636       -2     
  Lines        38629    38590      -39     
  Branches      7465     7459       -6     
===========================================
- Hits         29344    29332      -12     
+ Misses        5397     5371      -26     
+ Partials      3888     3887       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 2, 2024
@bmarty bmarty enabled auto-merge July 2, 2024 14:59
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jul 2, 2024
@bmarty bmarty merged commit 37eaa5e into develop Jul 2, 2024
29 of 30 checks passed
@bmarty bmarty deleted the feature/bma/elementWellKnown branch July 2, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Configure Element Call's widget URL using the new SDK API that parses the element.json wellknown
2 participants