Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Element Call's widget URL to be configured by the homeserver. #2971

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Allow Element Call's widget URL to be configured by the homeserver. #2971

merged 2 commits into from
Jul 2, 2024

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Jun 27, 2024 •
edited by pixlwave
Loading

  • use the SDK to make a GET requests and parse the response into an Element specific well-known settings struct
  • use those values to setup the ElementCall baseURL
  • keep the call baseURL override but separate it from the default URL and have it be nil by default

Closes #2911.

@stefanceriu stefanceriu requested a review from a team as a code owner June 27, 2024 08:09
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team June 27, 2024 08:09
@stefanceriu stefanceriu marked this pull request as draft June 27, 2024 08:09
@stefanceriu stefanceriu mentioned this pull request Jun 27, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 27, 2024 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against c96102e

@stefanceriu stefanceriu added the pr-feature for a new feature label Jun 27, 2024
pixlwave
pixlwave approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 📞

ElementX/Sources/Screens/Settings/DeveloperOptionsScreen/View/DeveloperOptionsScreen.swift Outdated Show resolved Hide resolved
ElementX/Sources/Screens/CallScreen/CallScreenViewModel.swift Outdated Show resolved Hide resolved
@pixlwave pixlwave changed the title Fixes #2911 - Make Element Call widget URL configurable Allow Element Call's widget URL to be configured by the homeserver. Jul 1, 2024
@pixlwave pixlwave marked this pull request as ready for review July 1, 2024 17:11
@pixlwave pixlwave enabled auto-merge (squash) July 1, 2024 17:12
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pixlwave pixlwave merged commit b2c9878 into develop Jul 2, 2024
6 checks passed
@pixlwave pixlwave deleted the stefan/elementWellKnown branch July 2, 2024 08:35
@bmarty bmarty mentioned this pull request Jul 2, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
pr-feature for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Make Element Call widget URL configurable
2 participants
@stefanceriu @pixlwave