Add a WebRegistrationScreen (not included in the flow yet).

[pixlwave]

This PR adds a screen that can perform registration using a helper URL. A follow-up PR will be made that includes the changes to the flow.

Note: This screen is based upon the login screen which also seems to include the logic in the Coordinator instead of the ViewModel. As it is temporary it didn't seem worth re-writing.

[github-actions]

	Fails
🚫	danger-swift failed.

Log

/var/folders/n3/x0zngmn15fzg2jfkglj4ys4w0000gn/T/danger/E370D59F-B65C-4CA3-99EE-ADDF6777B404/_tmp_dangerfile.swift:4:11: error: ambiguous use of 'lint'
SwiftLint.lint(inline: true)
          ^
Danger.SwiftLint:13:24: note: found this candidate
    public static func lint(inline: Bool = false, directory: String? = nil, configFile: String? = nil, strict: Bool = false, quiet: Bool = true, lintAllFiles: Bool = false, swiftlintPath: String? = nil) -> [Danger.SwiftLintViolation]
                       ^
Danger.SwiftLint:18:24: note: found this candidate
    public static func lint(_ lintStyle: Danger.SwiftLint.LintStyle = .modifiedAndCreatedFiles(directory: nil), inline: Bool = false, configFile: String? = nil, strict: Bool = false, quiet: Bool = true, swiftlintPath: Danger.SwiftLint.SwiftlintPath? = nil, markdownAction: (String) -> Void = markdown) -> [Danger.SwiftLintViolation]
                       ^
�[31mERROR: Dangerfile eval failed at Dangerfile.swift
�[0;0m�[31mERROR: Could not get the results JSON file at /var/folders/n3/x0zngmn15fzg2jfkglj4ys4w0000gn/T/danger/E370D59F-B65C-4CA3-99EE-ADDF6777B404/danger-response.json
�[0;0m

Generated by 🚫 dangerJS against d6074f9

[codecov]

Codecov Report

Attention: Patch coverage is 21.70543% with 202 lines in your changes missing coverage. Please review.

Project coverage is 77.31%. Comparing base (7536771) to head (d6074f9).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...egistrationScreen/View/WebRegistrationScreen.swift	0.00%	84 Missing ⚠️
...ationScreen/WebRegistrationScreenCoordinator.swift	0.00%	46 Missing ⚠️
...ervices/Authentication/AuthenticationService.swift	0.00%	28 Missing ⚠️
...trationScreen/WebRegistrationScreenViewModel.swift	0.00%	17 Missing ⚠️
...gistrationScreen/WebRegistrationScreenModels.swift	0.00%	13 Missing ⚠️
UnitTests/Sources/ClientProtocolTests.swift	83.33%	8 Missing ⚠️
ElementX/Sources/Services/Client/Client.swift	80.00%	4 Missing ⚠️
...ntX/Sources/Services/Client/ElementWellKnown.swift	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3281      +/-   ##
===========================================
- Coverage    77.76%   77.31%   -0.46%     
===========================================
  Files          725      731       +6     
  Lines        58788    59041     +253     
===========================================
- Hits         45716    45647      -69     
- Misses       13072    13394     +322     

Flag	Coverage Δ
unittests	68.76% <21.70%> (-0.17%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stefanceriu]

Couple of comments but lgtm 👍

[stefanceriu]

also seems to include the logic in the Coordinator instead of the ViewModel

Super weird, I was wondering why we did that and I think we just copied it from Riot. Why we did it like that there beats me. We should leave a todo in the code to get rid of this one and rewrite the other.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud