Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow registration on matrix.org using a custom helper URL. #3282

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

pixlwave
Copy link
Member

Follow on to #3281, this PR adds the screen into the authentication flow.

@pixlwave pixlwave requested a review from a team as a code owner September 13, 2024 17:37
@pixlwave pixlwave requested review from Velin92 and removed request for a team September 13, 2024 17:37
Copy link

github-actions bot commented Sep 13, 2024

Fails
🚫

danger-swift failed.

Log

/var/folders/0g/hj_q_pzx65bbjnslxz9n0src0000gn/T/danger/3407D2D5-0815-4633-8A0C-2CC692A1A062/_tmp_dangerfile.swift:4:11: error: ambiguous use of 'lint'
SwiftLint.lint(inline: true)
          ^
Danger.SwiftLint:13:24: note: found this candidate
    public static func lint(inline: Bool = false, directory: String? = nil, configFile: String? = nil, strict: Bool = false, quiet: Bool = true, lintAllFiles: Bool = false, swiftlintPath: String? = nil) -> [Danger.SwiftLintViolation]
                       ^
Danger.SwiftLint:18:24: note: found this candidate
    public static func lint(_ lintStyle: Danger.SwiftLint.LintStyle = .modifiedAndCreatedFiles(directory: nil), inline: Bool = false, configFile: String? = nil, strict: Bool = false, quiet: Bool = true, swiftlintPath: Danger.SwiftLint.SwiftlintPath? = nil, markdownAction: (String) -> Void = markdown) -> [Danger.SwiftLintViolation]
                       ^
�[31mERROR: Dangerfile eval failed at Dangerfile.swift
�[0;0m�[31mERROR: Could not get the results JSON file at /var/folders/0g/hj_q_pzx65bbjnslxz9n0src0000gn/T/danger/3407D2D5-0815-4633-8A0C-2CC692A1A062/danger-response.json
�[0;0m

Generated by 🚫 dangerJS against e666177

@pixlwave pixlwave added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 52.47525% with 48 lines in your changes missing coverage. Please review.

Project coverage is 77.17%. Comparing base (6cfe09b) to head (e666177).
Report is 5 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...owCoordinators/AuthenticationFlowCoordinator.swift 0.00% 42 Missing ⚠️
...tScreen/AuthenticationStartScreenCoordinator.swift 0.00% 4 Missing ⚠️
...artScreen/AuthenticationStartScreenViewModel.swift 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3282      +/-   ##
===========================================
+ Coverage    77.14%   77.17%   +0.02%     
===========================================
  Files          730      730              
  Lines        58993    59109     +116     
===========================================
+ Hits         45513    45615     +102     
- Misses       13480    13494      +14     
Flag Coverage Δ
unittests 68.74% <52.47%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave added the Trigger-PR-Build Uses to trigger alpha builds for PRs label Sep 13, 2024
Copy link

github-actions bot commented Sep 13, 2024

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/4bTex6

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, 🚀 it!

Base automatically changed from doug/web-registration-screen to develop September 16, 2024 10:03
Copy link

sonarcloud bot commented Sep 16, 2024

@pixlwave pixlwave merged commit 6efbf61 into develop Sep 16, 2024
9 of 11 checks passed
@pixlwave pixlwave deleted the doug/web-registration-flow branch September 16, 2024 12:05
@pixlwave pixlwave added pr-feature for a new feature and removed pr-wip for anything that isn't ready to ship and will be enabled at a later date labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature Trigger-PR-Build Uses to trigger alpha builds for PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants