Run CI on ubuntu-20.04 #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because the ubuntu-latest is resolved ubuntu-22.04, which is not compatible with otp 21.3 which this project supports. This also updates actions/checkout from v2 to v3, consequently resolving deprecation warning that prompts using Nodejs v16.
|
@sato11 Nice work! |
|
Thanks 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋 I came across and saw the CI not passing for some reason. This is the error message:
It seems this is because the ubuntu-latest is resolved ubuntu-22.04, which is not compatible with otp 21.3. Ref: https://github.com/erlef/setup-beam#compatibility-between-operating-system-and-erlangotp.
Downgrading os version might sound like a degradation, but I think we can excuse it since this is the way projects like plug run CI against older versions of otp.
This also updates actions/checkout from v2 to v3, consequently resolving deprecation warning that prompts using Nodejs v16. Ref: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
I validated that this fixes it after running the workflow in my fork, if you want to take a look 🙂