Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp-completion--company-match sometimes freeze my Emacs instance #4192

Open
2 of 3 tasks
sebastiencs opened this issue Oct 14, 2023 · 0 comments
Open
2 of 3 tasks

lsp-completion--company-match sometimes freeze my Emacs instance #4192

sebastiencs opened this issue Oct 14, 2023 · 0 comments
Labels

Comments

@sebastiencs
Copy link
Member

Thank you for the bug report

  • I am using the latest version of lsp-mode related packages.
  • I checked FAQ and Troubleshooting sections
  • You may also try reproduce the issue using clean environment using the following command: M-x lsp-start-plain

Bug description

lsp-completion--company-match is sometimes called with cached data (from previous completion):

When I auto-complete something at line 1, the auto-completion is fine.
But when I go to a line way below, let's say 1000, and start auto-completing, it's using some data from line 1 (specifically it's using the start-point at line 1) so the prefix is every characters between line 1 and 1000.

I'm not sure why we are using the same cache at 2 different places, there might be a reason.
A fix would be to re-compute the correct start-point

Steps to reproduce

Auto-complete at 2 different places (very distant lines)

Expected behavior

smooth completion

Which Language Server did you use?

rust-analyzer

OS

Linux

Error callstack

No response

Anything else?

No response

sebastiencs added a commit to sebastiencs/lsp-mode that referenced this issue Oct 14, 2023
Consider only the first line in `prefix`
sebastiencs added a commit to sebastiencs/lsp-mode that referenced this issue Oct 14, 2023
Consider only the first line in `prefix`
yyoncho pushed a commit that referenced this issue Oct 16, 2023
Consider only the first line in `prefix`
nverno added a commit to nverno/lsp-mode that referenced this issue Oct 16, 2023
* master: (27 commits)
  Rename blacklist to blocklist (emacs-lsp#4173)
  Introduce a function to disable a call for particular method for a server (emacs-lsp#4171)
  Fix `lsp-completion--company-match` freezing emacs-lsp#4192 (emacs-lsp#4193)
  Bump the magik language server to 0.8.1 (emacs-lsp#4195)
  Add configuration to use new experimental ondisk cache for lsp-kotlin (emacs-lsp#4138)
  lsp-erlang: add setting for types on hover (emacs-lsp#4188)
  Make it possible to override lsp-cmake server command (emacs-lsp#4182)
  lsp-erlang: update erlang-language-platform download file names (emacs-lsp#4187)
  clojure: add paredit refactorings
  Fix typo in php-guide.md (emacs-lsp#4183)
  Bump magik language server to 0.8.0 (emacs-lsp#4176)
  Bump elixir-ls version (emacs-lsp#4178)
  Remove unbalanced parenthesis and double-quote in comments (emacs-lsp#4177)
  MDX support (emacs-lsp#4141)
  lsp-erlang: Add semantic token support for erlang-language-platform (emacs-lsp#4166)
  lsp-mode: Fix sending shutdown message (emacs-lsp#4167)
  lsp-erlang: update ELP download file names (emacs-lsp#4165)
  Add Move language client (emacs-lsp#4155)
  Add support for python-lsp-server pyls-isort plugin. (emacs-lsp#4163)
  Updating Crystal LSP (emacs-lsp#4156)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant