Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Crystal LSP #4156

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Updating Crystal LSP #4156

merged 3 commits into from
Sep 1, 2023

Conversation

lanjoni
Copy link
Contributor

@lanjoni lanjoni commented Sep 1, 2023

Crystal LSP Mode

This PR aims to:

  • Update old crystal-lsp-mode to support Crystalline (old scry is deprecated)
  • Add a guide for installing and using lsp-mode with Crystal, allowing Emacs to become a powerful IDE for your development

@github-actions github-actions bot added documentation tutorial client One or more of lsp-mode language clients labels Sep 1, 2023
@lanjoni lanjoni changed the title fix/crystal lsp Updating Crystal LSP Sep 1, 2023
Copy link

@J0sueTM J0sueTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yyoncho
Copy link
Member

yyoncho commented Sep 1, 2023

Looks good. Link it here as well: https://github.com/emacs-lsp/lsp-mode/blob/master/mkdocs.yml#L169

@lanjoni
Copy link
Contributor Author

lanjoni commented Sep 1, 2023

Looks good. Link it here as well: https://github.com/emacs-lsp/lsp-mode/blob/master/mkdocs.yml#L169

Great! Done here f15a175

@yyoncho yyoncho enabled auto-merge (squash) September 1, 2023 13:07
@yyoncho yyoncho merged commit 271525a into emacs-lsp:master Sep 1, 2023
12 of 14 checks passed
nverno added a commit to nverno/lsp-mode that referenced this pull request Oct 16, 2023
* master: (27 commits)
  Rename blacklist to blocklist (emacs-lsp#4173)
  Introduce a function to disable a call for particular method for a server (emacs-lsp#4171)
  Fix `lsp-completion--company-match` freezing emacs-lsp#4192 (emacs-lsp#4193)
  Bump the magik language server to 0.8.1 (emacs-lsp#4195)
  Add configuration to use new experimental ondisk cache for lsp-kotlin (emacs-lsp#4138)
  lsp-erlang: add setting for types on hover (emacs-lsp#4188)
  Make it possible to override lsp-cmake server command (emacs-lsp#4182)
  lsp-erlang: update erlang-language-platform download file names (emacs-lsp#4187)
  clojure: add paredit refactorings
  Fix typo in php-guide.md (emacs-lsp#4183)
  Bump magik language server to 0.8.0 (emacs-lsp#4176)
  Bump elixir-ls version (emacs-lsp#4178)
  Remove unbalanced parenthesis and double-quote in comments (emacs-lsp#4177)
  MDX support (emacs-lsp#4141)
  lsp-erlang: Add semantic token support for erlang-language-platform (emacs-lsp#4166)
  lsp-mode: Fix sending shutdown message (emacs-lsp#4167)
  lsp-erlang: update ELP download file names (emacs-lsp#4165)
  Add Move language client (emacs-lsp#4155)
  Add support for python-lsp-server pyls-isort plugin. (emacs-lsp#4163)
  Updating Crystal LSP (emacs-lsp#4156)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client One or more of lsp-mode language clients documentation tutorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants