Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure container and resolver normalize the same way #94

Closed
wants to merge 1 commit into from
Closed

Make sure container and resolver normalize the same way #94

wants to merge 1 commit into from

Conversation

marcoow
Copy link

@marcoow marcoow commented Sep 23, 2014

This fixes e.g. #84

stefanpenner
stefanpenner reviewed Sep 23, 2014
View reviewed changes
dist/amd/isolated-container.js
@@ -8,6 +8,9 @@ define(
__exports__["default"] = function isolatedContainer(fullNames) {
var resolver = testResolver.get();
var container = new Ember.Container();
container.normalize = function(fullName) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

container.normalizeFullName -> https://github.com/emberjs/ember.js/blob/master/packages/ember-application/lib/system/application.js#L958

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But Ember Data's adapterFor etc. call container.lookup which calls this.normalize and that's where the problem is as ED looks for e.g. 'adapter:modelName' which is registered as 'adapter:model-name'.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/emberjs/ember.js/blob/master/packages/container/lib/container.js#L256

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting container.normalizeFullName doesn't work - or at least it doesn't fix my problem. ED still wouldn't find the adapters etc. that I define in needs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcoow maybe old version of ember? I have no idea what exists in stable, i only work in canary.

If this isn't in stable yet please feature detect accordingly.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefanpenner: yep, this is on 1.7.0 - I'll update this later.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefanpenner fixed that

@stefanpenner
Copy link
Member

travis appears unhappy

@marcoow
Copy link
Author

marcoow commented Oct 7, 2014

Yeah, seems to be a timeout:

INFO [karma]: Karma v0.10.10 server started at http://localhost:9876/
INFO [launcher]: Starting browser Firefox
INFO [Firefox 31.0.0 (Linux)]: Connected on socket R28WP-yuhWAO1sH_QIfX
DEBUG: 'DEBUG: For more advanced debugging, install the Ember Inspector from https://addons.mozilla.org/en-US/firefox/addon/ember-inspector/'
Firefox 31.0.0 (Linux): Executed 0 of 0 SUCCESS (0 secs / 0 secs)
 SUCCESS (0 secs / 0.018 secs)
 SUCCESS (0 secs / 0.076 secs)
 SUCCESS (0 secs / 0.099 secs)
 SUCCESS (0 secs / 0.121 secs)
 SUCCESS (0 secs / 0.149 secs)
 SUCCESS (0 secs / 0.17 secs)
 SUCCESS (0 secs / 0.194 secs)
No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.
The build has been terminated

Can you trigger a rebuild? I don't seem to have the permissions on the travis page.

@stefanpenner
Copy link
Member

re-triggering

@rwjblue
Copy link
Member

rwjblue commented Oct 28, 2014

@marcoow - We just landed a major refactor (thanks @dgeb), most of this functionality now lives in https://github.com/switchfly/ember-test-helpers, can you open a PR over there with this fix?

@rwjblue rwjblue closed this Oct 28, 2014
@marcoow marcoow mentioned this pull request Oct 29, 2014
Merged
@marcoow
Copy link
Author

marcoow commented Oct 29, 2014

see emberjs/ember-test-helpers#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcoow @stefanpenner @rwjblue