Make sure container and resolver normalize the same way #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var normalize = function(fullName) { | ||
| return resolver.normalize(fullName); | ||
| }; | ||
| if (Ember.typeOf(container.normalizeFullName) === 'function') { |
There was a problem hiding this comment.
Can you clarify via comment that this is for backward compat (and list the version that added normalizeFullName)? This will help us know when we can remove it in the future.
dgeb
added a commit
that referenced
this pull request
Nov 1, 2014
Make sure container and resolver normalize the same way
|
@marcoow Awesome - thanks for the note of clarification re: Ember version compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see rwjblue/ember-qunit#94