Ensure prior render is cleared when calling this.render.
#155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, calling `this.render` twice within the same test (without calling `this.clearRender()` in between) would cause any components created in the first render to never be destroyed (and therefore they cannot cleanup any listeners they created). This change essentially ensures that we call `clearRender` before each `this.render` invocation so that if a component had been previously instantiated it is cleared and reset.
|
Failure is due to issues on canary. I created emberjs/ember.js#13557 to track that upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, calling
this.rendertwice within the same test (without callingthis.clearRender()in between) would cause any components created in the first render to never be destroyed (and therefore they cannot cleanup any listeners they created).This change essentially ensures that we call
clearRenderbefore eachthis.renderinvocation so that if a component had been previously instantiated it is cleared and reset.Fixes #111.