Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure prior render is cleared when calling this.render. #155

Merged
merged 2 commits into from
May 25, 2016
Merged

Ensure prior render is cleared when calling this.render. #155

merged 2 commits into from
May 25, 2016

Commits on May 25, 2016

  1. Ensure prior render is cleared when calling this.render. 

    Previously, calling `this.render` twice within the same test (without
calling `this.clearRender()` in between) would cause any components
created in the first render to never be destroyed (and therefore they
cannot cleanup any listeners they created).

This change essentially ensures that we call `clearRender` before each
`this.render` invocation so that if a component had been previously
instantiated it is cleared and reset.
    Robert Jackson committed May 25, 2016
    Configuration menu
    Copy the full SHA
    d341f07 View commit details
    Browse the repository at this point in the history

  2. Allow canary failures for now.

    Robert Jackson committed May 25, 2016
    Configuration menu
    Copy the full SHA
    6e64e1e View commit details
    Browse the repository at this point in the history