Clean up and simplify setupRenderingContext #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
reviewed
Dec 31, 2017
| // In older Ember versions (2.4) the element itself is not stable, | ||
| // and therefore we cannot update the `this.element` until after the | ||
| // rendering is completed | ||
| context.element = document.querySelector('#ember-testing > .ember-view'); |
There was a problem hiding this comment.
I assume this will break once the RFC from @cibernox is implemented?
There was a problem hiding this comment.
It just changes to use the rootElement directly (based on a feature detect):
context.element = getRootElement();
At which point the various interaction helpers (which were just changed to use rootElement instead of this) and this.element will be back in sync...
rwjblue
force-pushed
the
refactor-setup-rendering-test
branch
from
52db7ce
to
3aef417
Compare
Moves core functionality into the importable `render` / `clearRender` / etc utility functions and out of the `setupRenderingContext` directly. This simplifies how the methods work together (since they no longer have access to _everything_ in closure scope), and sets the stage for an eventual deprecation of `this.render` and `this.clearRender`.
rwjblue
force-pushed
the
refactor-setup-rendering-test
branch
from
3aef417
to
26c7ad8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves core functionality into the importable
render/clearRender/ etc utility functions and out of thesetupRenderingContextdirectly.This simplifies how the methods work together (since they no longer have access to everything in closure scope), and sets the stage for an eventual deprecation of
this.renderandthis.clearRender.