Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up and simplify setupRenderingContext #296

Merged
merged 1 commit into from
Jan 1, 2018
Merged

Clean up and simplify setupRenderingContext #296

merged 1 commit into from
Jan 1, 2018

Commits on Dec 31, 2017

  1. Core: refactor setupRenderingContext 

    Moves core functionality into the importable `render` / `clearRender` /
etc utility functions and out of the `setupRenderingContext` directly.

This simplifies how the methods work together (since they no longer have
access to _everything_ in closure scope), and sets the stage for an
eventual deprecation of `this.render` and `this.clearRender`.
    @rwjblue
    rwjblue committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    26c7ad8 View commit details
    Browse the repository at this point in the history