Migrate CI to GitHub Actions. #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
approved these changes
Apr 21, 2020
rwjblue
force-pushed
the
migrate-to-github-actions
branch
from
e9f2b72
to
1a99615
Compare
Turbo87
reviewed
Apr 22, 2020
| - name: install dependencies | ||
| run: yarn install --frozen-lockfile | ||
| - name: test | ||
| run: node_modules/.bin/ember try:one ${{ matrix.ember-try-scenario }} --skip-cleanup |
There was a problem hiding this comment.
if we're using volta here, do we still need to reach into .bin or can we call ember directly?
There was a problem hiding this comment.
If we're using volta here, do we still need to reach into .bin or can we call ember directly?
Ya, thought about that, but we'd have to volta install ember-cli and in this case we don't actually need / want the global install to run (since we know for sure that we'd always want to defer).
There was a problem hiding this comment.
hmm, okay, then I misunderstood volta apparently. we could still use yarn ember though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.