Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate CI to GitHub Actions. #824

Merged
merged 3 commits into from
Apr 21, 2020
Merged

Migrate CI to GitHub Actions. #824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cdbe7d8
Migrate CI to GitHub Actions.
rwjblue Apr 21, 2020
8d6b06a
Use volta to pin Node and yarn versions.
rwjblue Apr 21, 2020
1a99615
Remove .travis.yml
rwjblue Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 66 additions & 0 deletions .github/workflows/ci-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
name: CI Build

on:
push:
branches:
- master
- 'v*'
pull_request:
schedule:
- cron: '0 3 * * *' # daily, at 3am

jobs:
test:
name: Tests
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: volta-cli@action@v1
with:
node-version: 10.x
- run: yarn install --frozen-lockfile
- run: yarn lint:js
- run: yarn test

floating-dependencies:
name: "Floating Dependencies"
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: volta-cli@action@v1
with:
node-version: 10.x
- run: yarn install --no-lockfile
- run: yarn test

try-scenarios:
name: "Try: ${{ matrix.ember-try-scenario }}"

runs-on: ubuntu-latest

needs: test

strategy:
fail-fast: true
matrix:
ember-try-scenario:
- ember-lts-3.8
- ember-lts-3.12
- ember-lts-3.16
- ember-release
- ember-beta
- ember-canary
- ember-default-with-jquery
- ember-without-application-wrapper

steps:
- uses: actions/checkout@v2
- uses: volta-cli@action@v1
with:
node-version: 12.x
- name: install dependencies
run: yarn install --frozen-lockfile
- name: test
run: node_modules/.bin/ember try:one ${{ matrix.ember-try-scenario }} --skip-cleanup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're using volta here, do we still need to reach into .bin or can we call ember directly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're using volta here, do we still need to reach into .bin or can we call ember directly?

Ya, thought about that, but we'd have to volta install ember-cli and in this case we don't actually need / want the global install to run (since we know for sure that we'd always want to defer).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, okay, then I misunderstood volta apparently. we could still use yarn ember though.

81 changes: 0 additions & 81 deletions .travis.yml
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
@ember/test-helpers
==============================================================================

[![Build Status](https://secure.travis-ci.org/emberjs/ember-test-helpers.svg?branch=master)](http://travis-ci.org/emberjs/ember-test-helpers)

A test-framework-agnostic set of helpers for testing Ember.js applications


Expand Down
4 changes: 4 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,5 +115,9 @@
"github": {
"release": true
}
},
"volta": {
"node": "10.20.1",
"yarn": "1.22.4"
}
}