-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] deprecate export gone from @ember/application/deprecations
#19668
Comments
Or do I misunderstand and deprecated features for 4.0 are already removed on canary? If so, then I guess this might lead to a lot of addon canary tests failing due to the removals, as many used addons might not have fully migrated yet? |
OK, I see that this is actually affecting all the deprecation stuff. I guess I have to just ignore failing canary builds for now, then, as this will probably be a more widespread issue for addons running canary tests. |
Fixes the following runtime error caused by an outdated transitive `ember-test-helpers` dependency: > Could not find module `@ember/application/deprecations` imported from `@ember/string/index` emberjs/ember.js#19668 https://github.com/emberjs/ember-qunit/blob/master/docs/migration.md
Fixes the following runtime error caused by an outdated transitive `@ember/string` dependency: > Could not find module `@ember/application/deprecations` imported from `@ember/string/index` emberjs/ember.js#19668
🐞 Describe the Bug
In current canary, this does not work anymore:
This is not documented anywhere as far as I've seen, but ember-test-helpers uses it and it seemed to have worked so far.
I made a PR there to fix this, but I guess this should not be dropped before 4.0.0 then..?
See: emberjs/ember-test-helpers#1066
🔬 Minimal Reproduction
I noticed in an addon running canary tests, e.g. see here:
https://github.com/fabscale/ember-graphql-client/pull/1/checks?check_run_id=3102803118#step:6:53
😕 Actual Behavior
Import used to work (up to current beta) but stopped working.
🤔 Expected Behavior
Import should continue to work, at least until 4.0.0 I guess?
🌍 Environment
The text was updated successfully, but these errors were encountered: