Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] deprecate export gone from @ember/application/deprecations #19668

Closed
mydea opened this issue Jul 19, 2021 · 2 comments
Closed

[Bug] deprecate export gone from @ember/application/deprecations #19668

mydea opened this issue Jul 19, 2021 · 2 comments

Comments

@mydea
Copy link
Contributor

mydea commented Jul 19, 2021

🐞 Describe the Bug

In current canary, this does not work anymore:

import { deprecate } from '@ember/application/deprecations`

This is not documented anywhere as far as I've seen, but ember-test-helpers uses it and it seemed to have worked so far.
I made a PR there to fix this, but I guess this should not be dropped before 4.0.0 then..?

See: emberjs/ember-test-helpers#1066

🔬 Minimal Reproduction

I noticed in an addon running canary tests, e.g. see here:
https://github.com/fabscale/ember-graphql-client/pull/1/checks?check_run_id=3102803118#step:6:53

😕 Actual Behavior

Import used to work (up to current beta) but stopped working.

🤔 Expected Behavior

Import should continue to work, at least until 4.0.0 I guess?

🌍 Environment

  • Ember: Canary
  • Node.js/npm: 14
  • OS: Ubuntu
  • Browser: Chrome (GH Actions)
@mydea
Copy link
Contributor Author

mydea commented Jul 19, 2021

Or do I misunderstand and deprecated features for 4.0 are already removed on canary? If so, then I guess this might lead to a lot of addon canary tests failing due to the removals, as many used addons might not have fully migrated yet?

@mydea
Copy link
Contributor Author

mydea commented Jul 19, 2021

OK, I see that this is actually affecting all the deprecation stuff. I guess I have to just ignore failing canary builds for now, then, as this will probably be a more widespread issue for addons running canary tests.

@mydea mydea closed this as completed Jul 19, 2021
buschtoens added a commit to ember-intl/ember-intl that referenced this issue Jan 20, 2022
Fixes the following runtime error caused by an outdated transitive `ember-test-helpers` dependency:

> Could not find module `@ember/application/deprecations` imported from `@ember/string/index`

emberjs/ember.js#19668

https://github.com/emberjs/ember-qunit/blob/master/docs/migration.md
buschtoens added a commit to ember-intl/ember-intl that referenced this issue Jan 20, 2022
Fixes the following runtime error caused by an outdated transitive `@ember/string` dependency:

> Could not find module `@ember/application/deprecations` imported from `@ember/string/index`

emberjs/ember.js#19668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant