Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update conversation when item is no longer available #169

Closed
3 tasks done
eliazzo opened this issue Apr 12, 2024 · 1 comment · Fixed by #226
Closed
3 tasks done

Update conversation when item is no longer available #169

eliazzo opened this issue Apr 12, 2024 · 1 comment · Fixed by #226
Assignees
@camelPhonso
Milestone
Messaging v1

Comments

@eliazzo
Copy link

eliazzo commented Apr 12, 2024

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Expected Behaviour

All conversations should see a message saying the item is unavailable eg
item unavailable

Current Behaviour

Conversation can continue (no change to conversation) when item is removed
@eliazzo eliazzo added this to the Messaging milestone Apr 12, 2024
@camelPhonso
Copy link
Contributor

Moved to blocked as it will need to wait on issue #183

@camelPhonso camelPhonso self-assigned this May 21, 2024
@camelPhonso camelPhonso mentioned this issue May 22, 2024
Merged
7 tasks
camelPhonso added a commit that referenced this issue May 24, 2024
@camelPhonso
feat: new util to retrieve all conversation ids associated with an item
78b21f0 
relates #169
camelPhonso added a commit that referenced this issue May 24, 2024
@camelPhonso
feat: new deleteItemHandler inserts notification to related conversat…
a1ad5b2 
…ions & deletes item

relates #169
camelPhonso added a commit that referenced this issue May 24, 2024
@camelPhonso
style: rename selectConversationByItemId to selectConversationsByItemId
621c0a6 
relates #169
camelPhonso added a commit that referenced this issue May 24, 2024
@camelPhonso
docs: documenting util return values / use cases
635ff46 
relates #169
camelPhonso added a commit that referenced this issue May 24, 2024
@camelPhonso
style: added y-axis margin to component
335cfd0 
relates #169
camelPhonso added a commit that referenced this issue May 24, 2024
@camelPhonso
refactor: rename markMessageAsRead to fit conventions
bcf4a22 
relates #169
camelPhonso added a commit that referenced this issue May 26, 2024
@camelPhonso
build: removed item_id foreign key from user_conversations to allow u…
a260570 
…pdating conversation on item deletion

relates #169
@camelPhonso camelPhonso mentioned this issue May 26, 2024
Merged
camelPhonso added a commit that referenced this issue May 29, 2024
@camelPhonso
refactor: declaring deleteHandler inside the component function body
1f345e2 
relates #169
camelPhonso added a commit that referenced this issue Jun 1, 2024
@camelPhonso
refactor: rename returned variable for better readability
7e014ad 
relates #169
camelPhonso added a commit that referenced this issue Jun 5, 2024
@camelPhonso
Merge branch 'dev' into #169/message-item-deleted
eaacdef
camelPhonso added a commit that referenced this issue Jun 5, 2024
@camelPhonso
fix: linting error
7fb31f3 
relates #169
camelPhonso added a commit that referenced this issue Jun 11, 2024
@camelPhonso
fix: merged latest changes from dev
2fc791a 
relates #169
camelPhonso added a commit that referenced this issue Jun 11, 2024
@camelPhonso
Merge branch 'dev' into #169/message-item-deleted
0ba4e52
eliazzo added a commit that referenced this issue Jun 14, 2024
@eliazzo
Merge pull request #226 from enBloc-org/#169/message-item-deleted
ed8dc43 
#169/message item deleted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camelPhonso camelPhonso

Labels
None yet
Projects
Kindly (enBloc)
Status: Done
Milestone
Messaging v1
Development

Successfully merging a pull request may close this issue.

#169/message item deleted enBloc-org/kindly
2 participants
@eliazzo @camelPhonso