-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#169/message item deleted #226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cool-creponne-3e1272 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nichgalzin
reviewed
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides that one naming suggestion I commented on below this is some hot stuff! Love it, and neatly done. Good job babes!
eliazzo
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #169
If an item is deleted all conversations related to that item will now receive a notification informing that it is no longer available. Conversations no longer get automatically deleted.
Files changed
DeleteButton.tsx
- edited the handler to callinsertSystemMessage
before deleting the itemmarkAsRead.ts
has been renamed tomarkMessageAsRead.ts
since we also have amarkConversationAsRead.ts
in the works. This change touched a few other files where we import the functionSystemMessageCard.tsx
- was re-styled slightly because it was sitting flat against the bottom of the wrapper at the start of conversationsitem_id
foreign key fromuser_conversations
tableselectConversationsByItemId.ts
- new util that returns all active conversations that relate to an iteminsertSystemMessage.ts
- added documentation to this util because I kept needing to check whether it need an id fromconversations
oruser_conversations
UI changes
Conversations now get a new
SystemMessageCard.tsx
added when the relevant item is deleted from the databaseChanges to Documentation
This PR did not require any additional documentation.
Tests
No new tests 😓 - testability for our components is yet again being worked on in another issue