Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 Add Storybook #221

Closed
camelPhonso opened this issue May 23, 2024 · 0 comments · Fixed by #228
Closed

📚 Add Storybook #221

camelPhonso opened this issue May 23, 2024 · 0 comments · Fixed by #228
Assignees

Comments

@camelPhonso
Copy link
Contributor

Expected Behaviour

Components should have some element of testing and the Developer Experience is due a few improvements:

  • Developers should be able to easily access a library of existing components for easy re-use
  • Developing new components should easily be brought in line with the visual guidelines of Kindly
  • Adding tests for component functionality should be made easy to help our continuous integration as the community of collaborators grows

Current Behaviour

Component files are currently organised within the folders structure of our code but can only be viewed by running the app and finding the component there or testing it in a new use-case.
There are no component tests of any kind happening at the moment and variations of the same component will sometimes surprise us and cause a last-minute redesign of the component.

Steps to Reproduce Suggestion

Storybook allows us to create our own component library.

  • Developers will be able to view a complete library of all available components
  • Tests can be automated to check the functionality of each component
  • Building new components becomes easier with a visual display that is isolated from the rest of the app and allows us to simulate infinite variations on the same component
  • Developers will only need to import their component to a storybook file and push that with their commit, so maintainability is easy
@camelPhonso camelPhonso added this to the Open source launch milestone May 23, 2024
@eliazzo eliazzo mentioned this issue May 24, 2024
3 tasks
@camelPhonso camelPhonso self-assigned this May 24, 2024
camelPhonso added a commit that referenced this issue May 24, 2024
camelPhonso added a commit that referenced this issue May 24, 2024
camelPhonso added a commit that referenced this issue May 24, 2024
camelPhonso added a commit that referenced this issue May 24, 2024
camelPhonso added a commit that referenced this issue May 24, 2024
camelPhonso added a commit that referenced this issue May 25, 2024
camelPhonso added a commit that referenced this issue May 25, 2024
camelPhonso added a commit that referenced this issue May 26, 2024
camelPhonso added a commit that referenced this issue May 27, 2024
camelPhonso added a commit that referenced this issue May 28, 2024
camelPhonso added a commit that referenced this issue May 28, 2024
nichgalzin added a commit that referenced this issue Jun 5, 2024
camelPhonso added a commit that referenced this issue Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant