#221/add storybook #228
Merged
#221/add storybook #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cool-creponne-3e1272 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nichgalzin
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
**Closes #221 **
📚 This PR adds Storybook to our stack and introduces a few basic story file examples for our components along with documentation changes explaining this addition to newcomers.
🎭 Playwright has been removed as it was the original testing suite - now replaced by Cypress for E2E and Storybook for component tests
Files changed
.eslintrc.json,package.json&package-lock.json- edited with the installation of Storybook and dependent add-ons./storybook/**- setup files for our storybook environment**.stories.tsx- story files for a few of our components. These are the start of our component library and can serve as examples for future implementations**.spec.ts- playwright test suites deleted as they are no longer in use.gitignore- edited to ignore new storybook log and all references to playwright have been removed to keep the file from bloatingTESTING.mdthe implementation of StorybookUI changes
No UI changes to the app but visual guides have been added to our documentation
Changes to Documentation
TESTING.mdupdated as described aboveTests
YES! 🦆 - Component stories have been added for the following components:
MessageCard.tsxItemCard.tsxSystemMessageCard.tsxConversationCard.tsx