build: undo some protobuf hacks, put some new ones in. #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use protobuf from HEAD to ensure we have the protocolbuffers/protobuf#3327 fix for CI and local builds. Users can opt to use a specific release tag with the ENVOY_PROTOBUF_COMMIT env var. * Remove the workaround for protocolbuffers/protobuf#3327 in do_ci.sh. * Remove the multiple protobuf versions that existed because protocolbuffers/protobuf#2508 wasn't merged. * Add some evil symlink stuff to get @protobuf_bzl inferred from wherever WORKSPACE points the envoy_dependencies path at. As a bonus, enabled more verbose build of external deps so we don't sit around for minutes on initial checkout with no activity indicator. This can be done safely now as everyone should be at Bazel 0.5.2.
|
We probably need to split this into 2 commits? |
|
Yeah, I thought we could try and sneak past that for a few commits, but it's probably best. We actually need 3 commits:
|
|
Closing out to split the commits. |
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: On bazel 3.7.2 we no longer can see Java error output in builds. Downgrading for now, since this significantly impedes development and debugging. Risk Level: Low Testing: Local & CI Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: On bazel 3.7.2 we no longer can see Java error output in builds. Downgrading for now, since this significantly impedes development and debugging. Risk Level: Low Testing: Local & CI Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use protobuf from HEAD to ensure we have the
Use consistent hash across NDEBUG/!NDEBUG builds. protocolbuffers/protobuf#3327 fix for CI and local
builds. Users can opt to use a specific release tag with the
ENVOY_PROTOBUF_COMMIT env var.
Remove the workaround for Use consistent hash across NDEBUG/!NDEBUG builds. protocolbuffers/protobuf#3327
in do_ci.sh.
Remove the multiple protobuf versions that existed because
add a key to ctx.action dict to prevent protoc losing the default env protocolbuffers/protobuf#2508 wasn't merged.
Add some evil symlink stuff to get @protobuf_bzl inferred from
wherever WORKSPACE points the envoy_dependencies path at.
As a bonus, enabled more verbose build of external deps so we don't sit
around for minutes on initial checkout with no activity indicator. This
can be done safely now as everyone should be at Bazel 0.5.2.