Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: undo some protobuf hacks, put some new ones in. #1299

Closed
wants to merge 1 commit into from
Closed

build: undo some protobuf hacks, put some new ones in. #1299

wants to merge 1 commit into from

Commits on Jul 20, 2017

  1. build: undo some protobuf hacks, put some new ones in. 

    * Use protobuf from HEAD to ensure we have the
  protocolbuffers/protobuf#3327 fix for CI and local
  builds. Users can opt to use a specific release tag with the
  ENVOY_PROTOBUF_COMMIT env var.

* Remove the workaround for protocolbuffers/protobuf#3327
  in do_ci.sh.

* Remove the multiple protobuf versions that existed because
  protocolbuffers/protobuf#2508 wasn't merged.

* Add some evil symlink stuff to get @protobuf_bzl inferred from
  wherever WORKSPACE points the envoy_dependencies path at.

As a bonus, enabled more verbose build of external deps so we don't sit
around for minutes on initial checkout with no activity indicator. This
can be done safely now as everyone should be at Bazel 0.5.2.
    @htuch
    htuch committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    93c9005 View commit details
    Browse the repository at this point in the history