tools: api_booster tool for upgrading Envoy APIs (tool only) #9329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a beachhead PR for a Clang Libtooling based workflow that automagically updates Envoy's source tree to the latest API version for every referenced package. So far, ths tool is only capable of inferring types and performing header fixups, later PRs will expand this. Risk level: Low Testing: Manual cleanup of all headers in source/ test/ and include/, all tests pass. Part of envoyproxy#8082 Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
lizan
suggested changes
Dec 12, 2019
Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
commented
Dec 12, 2019
| @@ -12,6 +12,10 @@ namespace Config { | |||
| namespace { | |||
|
|
|||
| TEST(ApiTypeOracleTest, All) { | |||
| // For proto descriptors only | |||
| static_cast<void>(envoy::config::filter::http::ip_tagging::v2::IPTagging::RequestType()); | |||
There was a problem hiding this comment.
This change and the BUILD fixes are not strictly part of the tooling, but they are nop changes to the rest of the tree that are needed to test the tool; they fix missing deps and linking requirements.
Signed-off-by: Harvey Tuch <htuch@google.com>
lizan
reviewed
Dec 13, 2019
Signed-off-by: Harvey Tuch <htuch@google.com>
lizan
approved these changes
Dec 13, 2019
| # Figure out where the LLVM include path is. We need to provide this | ||
| # explicitly as the api_booster is built inside the Bazel cache and doesn't | ||
| # know about this path. | ||
| # TODO(htuch): this is fragile and depends on Clang version, should figure out |
There was a problem hiding this comment.
from the previous PR, what do we actually include from versioned include?
There was a problem hiding this comment.
Copy+pasting:
If I don't declare this as -isystem, I see:
...clang-9.0/lib/clang/9.0.0/include/mmintrin.h:50:12: error: use of old-style cast [-Werror,-Wold-style-cast]
return (__m64)__builtin_ia32_vec_init_v2si(__i, 0);
since it doesn't recognize these libraries as system libs (and hence subject to relaxation of the warning).
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
htuch
added a commit
to htuch/envoy
that referenced
this pull request
Dec 13, 2019
This applies the API booster in envoyproxy#9329 to the Envoy tree. So far it just figures out the correct include headers based on encountered API protos, more to follow. Risk level: Low Testing: bazel test //test/.... Signed-off-by: Harvey Tuch <htuch@google.com>
htuch
added a commit
that referenced
this pull request
Dec 15, 2019
This applies the API booster in #9329 to the Envoy tree. So far it just figures out the correct include headers based on encountered API protos, more to follow. Risk level: Low Testing: bazel test //test/.... Signed-off-by: Harvey Tuch <htuch@google.com>
prakhag1
pushed a commit
to prakhag1/envoy
that referenced
this pull request
Jan 3, 2020
…oxy#9329) This is a beachhead PR for a Clang Libtooling based workflow that automagically updates Envoy's source tree to the latest API version for every referenced package. So far, ths tool is only capable of inferring types and performing header fixups, later PRs will expand this. Risk level: Low Testing: Manual cleanup of all headers in source/ test/ and include/, all tests pass. Part of envoyproxy#8082 Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: Prakhar <prakhar_au@yahoo.com>
prakhag1
pushed a commit
to prakhag1/envoy
that referenced
this pull request
Jan 3, 2020
This applies the API booster in envoyproxy#9329 to the Envoy tree. So far it just figures out the correct include headers based on encountered API protos, more to follow. Risk level: Low Testing: bazel test //test/.... Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: Prakhar <prakhar_au@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Tool only split from #9258, to simplify review)
This is a beachhead PR for a Clang Libtooling based workflow that automagically updates Envoy's
source tree to the latest API version for every referenced package. So far, ths tool is only capable
of inferring types and performing header fixups, later PRs will expand this.
Risk level: Low
Testing: Manual cleanup of all headers in source/ test/ and include/, all tests pass.
Part of #8082