Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: apply api booster to tree. #9347

Merged
merged 1 commit into from
Dec 15, 2019

Conversation

htuch
Copy link
Member

@htuch htuch commented Dec 13, 2019

This applies the API booster in #9329 to the Envoy tree. So far it just
figures out the correct include headers based on encountered API protos,
more to follow.

Risk level: Low
Testing: bazel test //test/....

Signed-off-by: Harvey Tuch htuch@google.com

This applies the API booster in envoyproxy#9329 to the Envoy tree. So far it just
figures out the correct include headers based on encountered API protos,
more to follow.

Risk level: Low
Testing: bazel test //test/....

Signed-off-by: Harvey Tuch <htuch@google.com>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@htuch
Copy link
Member Author

htuch commented Dec 14, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think clang_tidy is capable for large header changes (because it involves too many files) feel free to just merge.

@htuch htuch merged commit 7ff7cb4 into envoyproxy:master Dec 15, 2019
@htuch htuch deleted the api-booster-application branch December 15, 2019 13:27
prakhag1 pushed a commit to prakhag1/envoy that referenced this pull request Jan 3, 2020
This applies the API booster in envoyproxy#9329 to the Envoy tree. So far it just
figures out the correct include headers based on encountered API protos,
more to follow.

Risk level: Low
Testing: bazel test //test/....

Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Prakhar <prakhar_au@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants