Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot Cache shouldnt log resource content #599

Closed
arkodg opened this issue Oct 19, 2022 · 0 comments · Fixed by #601
Closed

Snapshot Cache shouldnt log resource content #599

arkodg opened this issue Oct 19, 2022 · 0 comments · Fixed by #601

Comments

@arkodg
Copy link
Contributor

arkodg commented Oct 19, 2022

The cache logs which resources were added or removed here, exposing sensitive information that is part of the xds config.
@arkodg arkodg mentioned this issue Oct 19, 2022
Closed
arkodg added a commit to arkodg/go-control-plane that referenced this issue Oct 21, 2022
@arkodg
rm printing resources in cache logs
e3e56e5 
Fixes: envoyproxy#599

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg mentioned this issue Oct 21, 2022
Merged
alecholmez pushed a commit that referenced this issue Oct 28, 2022
@arkodg
rm printing resources in cache logs (#601)
b7f08b4 
* rm printing resources in cache logs and add GetResourceNames helper method

Fixes: #599

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rm printing resources in cache logs arkodg/go-control-plane
1 participant
@arkodg