-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rm printing resources in cache logs #601
Conversation
Fixes: envoyproxy#599 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
we also have a similar log line here that would be good to update: https://github.com/envoyproxy/go-control-plane/blob/b9e8d765366d34116028760e6192d40d69628636/pkg/cache/v3/linear.go |
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, made some tiny nits if you wanted to address them
cc @alecholmez if you had any other notes
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@sunjayBhatia thanks for review, addressed the comments, can you ptal |
Nope looks good to me! |
Fixes: #599
Signed-off-by: Arko Dasgupta arko@tetrate.io