Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use source model EQLNUM region when generating a FlowNet #160

Merged
merged 84 commits into from
Sep 14, 2020
Merged

Use source model EQLNUM region when generating a FlowNet #160

merged 84 commits into from
Sep 14, 2020

Conversation

olelod
Copy link
Collaborator

@olelod olelod commented Sep 1, 2020 •
edited
Loading

There are a lot of parameters to history match when we use individual SATNUM/EQLNUM. To limit this number we can use the original models' SATNUM/EQLNUM.

Contributor checklist

  • 🎉 This PR closes High degrees of freedom with individual satnum/eqlnum #139.
  • 📜 I have broken down my PR into the following tasks:
    • Assign eqlnum regions from simulation to FlowNet model.
    • Assign satnum regions from simulation to FlowNet model
    • Testing
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md.
  • 📚 I have considered updating the documentation.

@olelod
observation errors in config file, also passing the full config into …
bc263e8 
…create_ert_setup
@olelod
Merge branch 'master' into i120-move-obs-unc-to-config-yaml
0bc00d7
@olelod
some fixes
42ad6a4
@olelod
some fixes
9bc9447
@olelod
changing branch on flownet-testdata
cacb5c6
@olelod
fix merge conflict
283cb4a
@olelod
fixup
2ad1909
@olelod
black
f7c2ea8
@olelod
minor fix
5fcd4e6
@olelod
Merge branch 'master' into i120-move-obs-unc-to-config-yaml
d22b98d
@olelod
changes after review
a3f057d
@olelod
changes after code review
05b8e9d
@olelod
removed a couple of unnecessarylines
abb5d2d
@olelod
Merge branch 'master' into i120-move-obs-unc-to-config-yaml
498998a
@olelod
changing to master branch on flownet-testdata
e97a737
@olelod
WGPR removed from Egg ci_config on testdata-repo
ad61b12
@olelod
Merge branch 'master' into observation-vectors-in-config-yaml
e596092
@olelod
fixed typo
4e77a08
@olelod
only vectors actually used needs specification in config YAML
05f4246
@olelod
testdata branch changed to master
52e0721
@olelod
Merge branch 'master' into observation-vectors-in-config-yaml
4634116
@olelod
added possibility for injection rates in yamlobs template
1cb14bb
@olelod
small fix to yamlobs
fad4d71
@olelod
fix
d61f3f6
@olelod
fix
b455302
@olelod
fix
97ae33f
@olelod
new black
b867ccc
@olelod
new black
b393f94
@olelod
change branch on testdata
2e76e52
@olelod
added entry to CHANGELOG
56b958c
wouterjdb
wouterjdb suggested changes Sep 14, 2020
View reviewed changes
.github/workflows/flownet.yml Outdated Show resolved Hide resolved
src/flownet/ahm/_run_ahm.py Outdated Show resolved Hide resolved
src/flownet/ahm/_run_ahm.py Outdated Show resolved Hide resolved
src/flownet/data/from_flow.py Outdated Show resolved Hide resolved
@wouterjdb wouterjdb marked this pull request as ready for review September 14, 2020 10:42
@anders-kiaer anders-kiaer changed the title I139 eqlnum satnum regions EQLNUM and SATNUM regions Sep 14, 2020
@wouterjdb wouterjdb changed the title EQLNUM and SATNUM regions Use source model EQLNUM region when generating a FlowNet Sep 14, 2020
@wouterjdb wouterjdb self-requested a review September 14, 2020 15:11
wouterjdb
wouterjdb approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@wouterjdb wouterjdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@anders-kiaer anders-kiaer merged commit 88e6b6c into master Sep 14, 2020
@anders-kiaer anders-kiaer deleted the i139-eqlnum-satnum-regions branch September 14, 2020 15:21
@olelod olelod mentioned this pull request Sep 15, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterjdb wouterjdb wouterjdb approved these changes

@anders-kiaer anders-kiaer Awaiting requested review from anders-kiaer

Assignees

@olelod olelod

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

High degrees of freedom with individual satnum/eqlnum
3 participants
@olelod @wouterjdb @anders-kiaer