Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Dialyzer-specific problem matcher #182

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Remove Dialyzer-specific problem matcher #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76d3194
fix: remove dialyzer problem matcher
btkostner Mar 23, 2023
e0688a8
remove dialyzer problem matcher test
btkostner Mar 23, 2023
1a99452
remove dist problem matcher
btkostner Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions .github/elixir-matchers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,22 +57,6 @@
"column": 3
}
]
},
{
"owner": "elixir-dialyzerOutputDefault",
"severity": "warning",
"pattern": [
{
"regexp": "^(.*):(\\d+):(.*)",
"file": 1,
"line": 2,
"code": 3
},
{
"regexp": "^(.*)$",
"message": 1
}
]
}
]
}
19 changes: 0 additions & 19 deletions __tests__/problem-matchers.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ async function all() {
await testElixirMixCompileWarning()
await testElixirMixTestFailure()
await testElixirCredoOutputDefault()
await testElixirDialyzerOutputDefault()
}

async function testElixirMixCompileError() {
Expand Down Expand Up @@ -74,24 +73,6 @@ async function testElixirCredoOutputDefault() {
assert.equal(column, '7')
}

async function testElixirDialyzerOutputDefault() {
const [messagePattern, filePattern] = problemMatcher.find(
({ owner }) => owner === 'elixir-dialyzerOutputDefault',
).pattern

const firstOutput = 'lib/test.ex:15:invalid_contract'
const secondOutput =
'The @spec for the function does not match the success typing of the function.'

const [, file, line, code] = firstOutput.match(messagePattern.regexp)
assert.equal(file, 'lib/test.ex')
assert.equal(line, '15')
assert.equal(code, 'invalid_contract')

const [, message] = secondOutput.match(filePattern.regexp)
assert.equal(message, secondOutput)
}

all()
.then(() => process.exit(0))
.catch((err) => {
Expand Down
16 changes: 0 additions & 16 deletions dist/.github/elixir-matchers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,22 +57,6 @@
"column": 3
}
]
},
{
"owner": "elixir-dialyzerOutputDefault",
"severity": "warning",
"pattern": [
{
"regexp": "^(.*):(\\d+):(.*)",
"file": 1,
"line": 2,
"code": 3
},
{
"regexp": "^(.*)$",
"message": 1
}
]
}
]
}