Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go to 1.21.13/1.22.6 #18419

Closed
8 tasks done
ivanvc opened this issue Aug 8, 2024 · 10 comments
Closed
8 tasks done

Bump Go to 1.21.13/1.22.6 #18419

ivanvc opened this issue Aug 8, 2024 · 10 comments

Comments

@ivanvc
Copy link
Member

ivanvc commented Aug 8, 2024

What would you like to be added?

Go versions 1.21.13 and 1.22.6 were released two days ago. Although they don't include any security fixes, our guideline states that we aim to keep the Go version up to date.

Completion tracking below:

Refer to previous issues and their pull requests as a reference, i.e., #18269.

Why is this needed?

To keep the project up to date with the latest released Go version.

@ivanvc
Copy link
Member Author

ivanvc commented Aug 8, 2024

@henrybear327, do you want to work on this?

@henrybear327
Copy link
Contributor

henrybear327 commented Aug 8, 2024

/assign @henrybear327

@ivanvc yes I do want to work on this :)

thank you!

henrybear327 added a commit to henrybear327/etcd that referenced this issue Aug 8, 2024
henrybear327 added a commit to henrybear327/etcd that referenced this issue Aug 8, 2024
henrybear327 added a commit to henrybear327/etcd that referenced this issue Aug 8, 2024
Reference: etcd-io#18419
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
henrybear327 added a commit to henrybear327/etcd that referenced this issue Aug 8, 2024
Reference: etcd-io#18419
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
henrybear327 added a commit to henrybear327/etcd that referenced this issue Aug 8, 2024
Reference: etcd-io#18419

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
henrybear327 added a commit to henrybear327/etcd that referenced this issue Aug 8, 2024
Reference: etcd-io#18419
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
henrybear327 added a commit to henrybear327/etcd that referenced this issue Aug 8, 2024
Reference: etcd-io#18419

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
henrybear327 added a commit to henrybear327/bbolt that referenced this issue Aug 8, 2024
Reference: etcd-io/etcd#18419
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
henrybear327 added a commit to henrybear327/bbolt that referenced this issue Aug 8, 2024
Reference: etcd-io/etcd#18419
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
henrybear327 added a commit to henrybear327/bbolt that referenced this issue Aug 8, 2024
Reference: etcd-io/etcd#18419

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
henrybear327 added a commit to henrybear327/raft that referenced this issue Aug 8, 2024
Reference: etcd-io/etcd#18419
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
henrybear327 added a commit to henrybear327/gofail that referenced this issue Aug 8, 2024
Reference: etcd-io/etcd#18419
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@henrybear327
Copy link
Contributor

@ivanvc we probably would like to

  • add etcd-io/gofail to the list
  • move CHANGELOG to its dedicated category, since all 4 repos need to have their respective CHANGELOG updated

What do you think :)

@ivanvc
Copy link
Member Author

ivanvc commented Aug 8, 2024

add etcd-io/gofail to the list

Added!

move CHANGELOG to its dedicated category, since all 4 repos need to have their respective CHANGELOG updated

Because the other repositories have fewer releases and contributors, I noticed that, at least for Bbolt, Benjamin does it when preparing the next release.

@henrybear327
Copy link
Contributor

add etcd-io/gofail to the list

Added!

Thanks!

move CHANGELOG to its dedicated category, since all 4 repos need to have their respective CHANGELOG updated

Because the other repositories have fewer releases and contributors, I noticed that, at least for Bbolt, Benjamin does it when preparing the next release.

Oops, I have done it for all...

henrybear327 added a commit to henrybear327/raft that referenced this issue Aug 8, 2024
Reference: etcd-io/etcd#18419
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
henrybear327 added a commit to henrybear327/etcd that referenced this issue Aug 8, 2024
Reference: etcd-io#18419

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Co-authored-by: Iván Valdés Castillo <iv@nvald.es>
@henrybear327
Copy link
Contributor

We can close this issue now! :) Thanks everyone for the quick review and comments!

@jmhbnz
Copy link
Member

jmhbnz commented Aug 8, 2024

Thanks for ticking all these off so quickly team, nice work.

@jmhbnz jmhbnz closed this as completed Aug 8, 2024
@henrybear327
Copy link
Contributor

@ivanvc we forget to add Auger :(

@ivanvc
Copy link
Member Author

ivanvc commented Aug 12, 2024

@jmhbnz, when I started picking up this task, we listed only three repos: etcd, raft and bbolt. Should we start adding more repos? Do you suggest including gofail and auger from now on? (Some repositories tbh I never checked what they do 🙈)

Link to etcd-io/auger#91

@jmhbnz
Copy link
Member

jmhbnz commented Aug 12, 2024

@jmhbnz, when I started picking up this task, we listed only three repos: etcd, raft and bbolt. Should we start adding more repos? Do you suggest including gofail and auger from now on?

It is less critical that we update gofail and auger in such a timely fashion, our big three repositories, etcd, bbolt, and raft should continue to be prioritised. If you have time to include others in planning please feel free.

a-nych pushed a commit to a-nych/etcd that referenced this issue Oct 16, 2024
Reference: etcd-io#18419
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
a-nych pushed a commit to a-nych/etcd that referenced this issue Oct 16, 2024
Reference: etcd-io#18419

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Co-authored-by: Iván Valdés Castillo <iv@nvald.es>
a-nych pushed a commit to a-nych/etcd that referenced this issue Oct 16, 2024
Reference: etcd-io#18419
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
a-nych pushed a commit to a-nych/etcd that referenced this issue Oct 16, 2024
Reference: etcd-io#18419

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Co-authored-by: Iván Valdés Castillo <iv@nvald.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants