[2024-08-08] Bump dependency updates identified by dependabot #18418

henrybear327 · 2024-08-08T12:13:42Z

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

This pull request completes this week's etcd dependency updates following our dependency roster and dependency management instructions.

Summary of actions

Bumped
- bump golang.org/x/sys from 0.22.0 to 0.23.0
  - build(deps): bump golang.org/x/sys from 0.22.0 to 0.23.0 in /tools/mod #18406
  - build(deps): bump golang.org/x/sys from 0.22.0 to 0.23.0 #18402
- bump golang.org/x/sync from 0.7.0 to 0.8.0
  - build(deps): bump golang.org/x/sync from 0.7.0 to 0.8.0 in /tools/mod #18405
- bump golang.org/x/time from 0.5.0 to 0.6.0
  - build(deps): bump golang.org/x/time from 0.5.0 to 0.6.0 #18401
- bump github.com/alexfalkowski/gocovmerge from v1.3.9 to v1.3.13
  - [2024-08-08] Bump dependency updates identified by dependabot #18418 (comment)
- bump golang.org/x/crypto from 0.25.0 to 0.26.0
  - Due to bump github.com/alexfalkowski/gocovmerge from v1.3.9 to v1.3.13
- bump golang.org/x/net from 0.27.0 to 0.28.0
  - Due to bump github.com/alexfalkowski/gocovmerge from v1.3.9 to v1.3.13
- bump golang.org/x/text from 0.16.0 to 0.17.0
  - Due to bump github.com/alexfalkowski/gocovmerge from v1.3.9 to v1.3.13
Closed (fully indirect)
- bump github.com/zmap/zlint/v3 from 3.5.0 to 3.6.3
  - build(deps): bump github.com/zmap/zlint/v3 from 3.5.0 to 3.6.3 in /tools/mod #18407
- bump github.com/mgechev/revive from 1.3.7 to 1.3.9
  - build(deps): bump github.com/mgechev/revive from 1.3.7 to 1.3.9 in /tools/mod #18404
- bump golang.org/x/mod from 0.18.0 to 0.20.0
  - build(deps): bump golang.org/x/mod from 0.18.0 to 0.20.0 in /tools/mod #18403

codecov-commenter · 2024-08-08T12:34:24Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.00%. Comparing base (bb62635) to head (da4002b).

❗ Current head da4002b differs from pull request most recent head fe9218d

Please upload reports for the commit fe9218d to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 420 files with indirect coverage changes

@@            Coverage Diff            @@
##           main   #18418       +/-   ##
=========================================
+ Coverage      0   69.00%   +69.00%     
=========================================
  Files         0      420      +420     
  Lines         0    35475    +35475     
=========================================
+ Hits          0    24478    +24478     
- Misses        0     9582     +9582     
- Partials      0     1415     +1415

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb62635...fe9218d. Read the comment docs.

henrybear327 · 2024-08-08T12:56:09Z

@ivanvc 1.22.6 is out, should I bump the go version in another PR? :)

henrybear327 · 2024-08-08T13:10:58Z

/retest

henrybear327 · 2024-08-08T15:32:17Z

/retest

ivanvc · 2024-08-08T16:21:39Z

@ivanvc 1.22.6 is out, should I bump the go version in another PR? :)

I created issue #18419 to track this update. Thanks for the heads up, @henrybear327 :)

ivanvc

LGTM. Thanks, @henrybear327

tools/mod/go.mod

….1.3.13 In tools/mod directory, I executed the following instructions to - go get github.com/alexfalkowski/gocovmerge@none - Set `go 1.22` in the go.mod file - go get github.com/alexfalkowski/gocovmerge@v1.3.13 - go mod tidy Reference: - etcd-io#18418 (comment) - alexfalkowski/gocovmerge#87 - https://github.com/alexfalkowski/gocovmerge/releases/tag/v1.3.12

….1.3.13 In tools/mod directory, I executed the following instructions to - go get github.com/alexfalkowski/gocovmerge@none - Set `go 1.22` in the go.mod file - go get github.com/alexfalkowski/gocovmerge@v1.3.13 - go mod tidy Reference: - etcd-io#18418 (comment) - alexfalkowski/gocovmerge#87 - https://github.com/alexfalkowski/gocovmerge/releases/tag/v1.3.12 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

Reference: - etcd-io#18405 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

Reference: - etcd-io#18401 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

Reference: - etcd-io#18406 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

Due to bumping github.com/alexfalkowski/gocovmerge Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

ahrtr · 2024-08-08T19:46:24Z

@henrybear327 Please resolve the workflow failure pull-etcd-verify, thx

Due to bumping github.com/alexfalkowski/gocovmerge Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

henrybear327 · 2024-08-08T19:51:25Z

@henrybear327 Please resolve the workflow failure pull-etcd-verify, thx

@ahrtr it's resolved! Due to the PR done by @ivanvc and the fast upstream release, I added 39d3e25 and this caused quite some dependencies to be updated.

Please see the latest commits that I have posted! Thank you!

ivanvc

LGTM on green. Thanks, @henrybear327.
Could you please also update the pull request description to mention the update to x/net, x/crypto, and x/text?

henrybear327 · 2024-08-08T20:17:47Z

/retest

henrybear327 · 2024-08-08T20:20:30Z

LGTM on green. Thanks, @henrybear327. Could you please also update the pull request description to mention the update to x/net, x/crypto, and x/text?

@ivanvc updated as requested, actually mentioning github.com/alexfalkowski/gocovmerge, too. Please take a look! Thank you! :)

ahrtr

LGTM

Thanks

k8s-ci-robot · 2024-08-08T20:34:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, henrybear327, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ahrtr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

henrybear327 · 2024-08-08T20:39:38Z

/retest

The go directive from the go.mod file should be set to the minimum version required to compile packages from the module, and use toolchain to specify the latest go version [2]. This project's code should work fine with any version greater than 1.22. It will avoid projects that depend on this package getting a go directive version bump every time there's a new version of this dependency. Please see a similar issue we had during the etcd dependency update [1]. Reference: [1] etcd-io/etcd#18418 (comment) [2] alexfalkowski/gocovmerge#87

The go directive from the go.mod file should be set to the minimum version required to compile packages from the module, and use toolchain to specify the latest go version [2]. This project's code should work fine with any version greater than 1.22. It will avoid projects that depend on this package getting a go directive version bump every time there's a new version of this dependency. Please see a similar issue we had during the etcd dependency update [1]. Reference: [1] etcd-io/etcd#18418 (comment) [2] alexfalkowski/gocovmerge#87 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

….1.3.13 In tools/mod directory, I executed the following instructions to - go get github.com/alexfalkowski/gocovmerge@none - Set `go 1.22` in the go.mod file - go get github.com/alexfalkowski/gocovmerge@v1.3.13 - go mod tidy Reference: - etcd-io#18418 (comment) - alexfalkowski/gocovmerge#87 - https://github.com/alexfalkowski/gocovmerge/releases/tag/v1.3.12 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

k8s-ci-robot added area/clientv3 area/etcdctl area/etcdutl area/testing area/tooling size/L labels Aug 8, 2024

henrybear327 force-pushed the dependencies/08_08_24 branch 3 times, most recently from c9cfb62 to b3241c2 Compare August 8, 2024 12:27

henrybear327 force-pushed the dependencies/08_08_24 branch from b3241c2 to cfe12e3 Compare August 8, 2024 12:35

ivanvc approved these changes Aug 8, 2024

View reviewed changes

tools/mod/go.mod Show resolved Hide resolved

henrybear327 force-pushed the dependencies/08_08_24 branch from cfe12e3 to 471dc46 Compare August 8, 2024 18:48

henrybear327 force-pushed the dependencies/08_08_24 branch from 471dc46 to 24d03ba Compare August 8, 2024 19:23

henrybear327 requested a review from ivanvc August 8, 2024 19:23

henrybear327 added 4 commits August 8, 2024 21:24

dependency: bump golang.org/x/sync from 0.7.0 to 0.8.0

47f73f4

Reference: - etcd-io#18405 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

dependency: bump golang.org/x/time from 0.5.0 to 0.6.0

cfe806a

Reference: - etcd-io#18401 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

dependency: bump golang.org/x/sys from 0.22.0 to 0.23.0

f071fde

Reference: - etcd-io#18406 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

henrybear327 force-pushed the dependencies/08_08_24 branch from 24d03ba to f071fde Compare August 8, 2024 19:24

henrybear327 added 2 commits August 8, 2024 21:40

dependency: bump golang.org/x/crypto from 0.25.0 to 0.26.0

5c290d1

Due to bumping github.com/alexfalkowski/gocovmerge Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

dependency: bump golang.org/x/net from 0.27.0 to 0.28.0

8eb943d

Due to bumping github.com/alexfalkowski/gocovmerge Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

dependency: bump golang.org/x/text from 0.16.0 to 0.17.0

fe9218d

Due to bumping github.com/alexfalkowski/gocovmerge Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

k8s-ci-robot added the area/performance label Aug 8, 2024

ivanvc approved these changes Aug 8, 2024

View reviewed changes

ahrtr approved these changes Aug 8, 2024

View reviewed changes

k8s-ci-robot added the approved label Aug 8, 2024

ahrtr added the stage/merge-when-tests-green label Aug 8, 2024

ahrtr merged commit d57a793 into etcd-io:main Aug 8, 2024
47 checks passed

henrybear327 deleted the dependencies/08_08_24 branch August 8, 2024 21:05

henrybear327 mentioned this pull request Aug 12, 2024

Move the go directive version to toolchain etcd-io/auger#91

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[2024-08-08] Bump dependency updates identified by dependabot #18418

[2024-08-08] Bump dependency updates identified by dependabot #18418

henrybear327 commented Aug 8, 2024 •

edited

Loading

codecov-commenter commented Aug 8, 2024 •

edited

Loading

henrybear327 commented Aug 8, 2024

henrybear327 commented Aug 8, 2024

henrybear327 commented Aug 8, 2024

ivanvc commented Aug 8, 2024

ivanvc left a comment

ahrtr commented Aug 8, 2024

henrybear327 commented Aug 8, 2024

ivanvc left a comment

henrybear327 commented Aug 8, 2024

henrybear327 commented Aug 8, 2024 •

edited

Loading

ahrtr left a comment

k8s-ci-robot commented Aug 8, 2024

henrybear327 commented Aug 8, 2024

[2024-08-08] Bump dependency updates identified by dependabot #18418

[2024-08-08] Bump dependency updates identified by dependabot #18418

Conversation

henrybear327 commented Aug 8, 2024 • edited Loading

codecov-commenter commented Aug 8, 2024 • edited Loading

Codecov Report

henrybear327 commented Aug 8, 2024

henrybear327 commented Aug 8, 2024

henrybear327 commented Aug 8, 2024

ivanvc commented Aug 8, 2024

ivanvc left a comment

Choose a reason for hiding this comment

ahrtr commented Aug 8, 2024

henrybear327 commented Aug 8, 2024

ivanvc left a comment

Choose a reason for hiding this comment

henrybear327 commented Aug 8, 2024

henrybear327 commented Aug 8, 2024 • edited Loading

ahrtr left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Aug 8, 2024

henrybear327 commented Aug 8, 2024

henrybear327 commented Aug 8, 2024 •

edited

Loading

codecov-commenter commented Aug 8, 2024 •

edited

Loading

henrybear327 commented Aug 8, 2024 •

edited

Loading