tests: Migrate alarm tests to common framework #13823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tests/framework/e2e/etcdctl.go # tests/framework/interface.go
Codecov Report
@@ Coverage Diff @@
## main #13823 +/- ##
==========================================
- Coverage 72.55% 72.35% -0.21%
==========================================
Files 467 467
Lines 38280 38280
==========================================
- Hits 27773 27696 -77
- Misses 8717 8777 +60
- Partials 1790 1807 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nic-chen
changed the title
serathius
reviewed
Mar 19, 2022
tests/framework/interface.go
Outdated
| @@ -41,6 +41,7 @@ type Client interface { | |||
| HashKV(rev int64) ([]*clientv3.HashKVResponse, error) | |||
| Health() error | |||
| Defragment(opts config.DefragOption) error | |||
| Alarm(cmd string, member *clientv3.AlarmMember) (*clientv3.AlarmResponse, error) | |||
There was a problem hiding this comment.
We should follow client interface, let's have separate AlarmList and AlarmDisarm calls.
serathius
approved these changes
Mar 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13637
cc @serathius @ptabor @spzala @ahrtr to review when you have time, thanks.