-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Migrate alarm tests to common framework #13823
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
dca5874
tests: Migrate key value Get to common framework
nic-chen 3e657bd
tests: Migrate key value Get to common framework
nic-chen e9fa171
fix test fail
nic-chen 02516ab
Merge branch 'main' into tests/ctl-alarm
nic-chen 527edd3
fix alarm test
nic-chen bb78560
fix: set cluster size to 1 to avoid unstable
nic-chen 89146aa
chore: delete useless file
nic-chen c6488a2
fix review
nic-chen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,103 @@ | ||
// Copyright 2022 The etcd Authors | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package common | ||
|
||
import ( | ||
"os" | ||
"strings" | ||
"testing" | ||
"time" | ||
|
||
clientv3 "go.etcd.io/etcd/client/v3" | ||
"go.etcd.io/etcd/tests/v3/framework/config" | ||
"go.etcd.io/etcd/tests/v3/framework/testutils" | ||
) | ||
|
||
func TestAlarm(t *testing.T) { | ||
testRunner.BeforeTest(t) | ||
clus := testRunner.NewCluster(t, config.ClusterConfig{ClusterSize: 1, QuotaBackendBytes: int64(13 * os.Getpagesize())}) | ||
defer clus.Close() | ||
testutils.ExecuteWithTimeout(t, 10*time.Second, func() { | ||
// test small put still works | ||
smallbuf := strings.Repeat("a", 64) | ||
if err := clus.Client().Put("1st_test", smallbuf, config.PutOptions{}); err != nil { | ||
t.Fatalf("alarmTest: put kv error (%v)", err) | ||
} | ||
|
||
// write some chunks to fill up the database | ||
buf := strings.Repeat("b", os.Getpagesize()) | ||
for { | ||
if err := clus.Client().Put("2nd_test", buf, config.PutOptions{}); err != nil { | ||
if !strings.Contains(err.Error(), "etcdserver: mvcc: database space exceeded") { | ||
t.Fatal(err) | ||
} | ||
break | ||
} | ||
} | ||
|
||
// quota alarm should now be on | ||
alarmResp, err := clus.Client().Alarm("list", nil) | ||
if err != nil { | ||
t.Fatalf("alarmTest: Alarm error (%v)", err) | ||
} | ||
|
||
// check that Put is rejected when alarm is on | ||
if err := clus.Client().Put("3rd_test", smallbuf, config.PutOptions{}); err != nil { | ||
if !strings.Contains(err.Error(), "etcdserver: mvcc: database space exceeded") { | ||
t.Fatal(err) | ||
} | ||
} | ||
|
||
// get latest revision to compact | ||
sresp, err := clus.Client().Status() | ||
if err != nil { | ||
t.Fatalf("get endpoint status error: %v", err) | ||
} | ||
var rvs int64 | ||
for _, resp := range sresp { | ||
if resp != nil && resp.Header != nil { | ||
rvs = resp.Header.Revision | ||
break | ||
} | ||
} | ||
|
||
// make some space | ||
_, err = clus.Client().Compact(rvs, config.CompactOption{Physical: true, Timeout: 10 * time.Second}) | ||
if err != nil { | ||
t.Fatalf("alarmTest: Compact error (%v)", err) | ||
} | ||
|
||
if err = clus.Client().Defragment(config.DefragOption{Timeout: 10 * time.Second}); err != nil { | ||
t.Fatalf("alarmTest: defrag error (%v)", err) | ||
} | ||
|
||
// turn off alarm | ||
for _, alarm := range alarmResp.Alarms { | ||
m := &clientv3.AlarmMember{ | ||
MemberID: alarm.MemberID, | ||
Alarm: alarm.Alarm, | ||
} | ||
_, err = clus.Client().Alarm("disarm", m) | ||
if err != nil { | ||
t.Fatalf("alarmTest: Alarm error (%v)", err) | ||
} | ||
} | ||
|
||
// put one more key below quota | ||
if err := clus.Client().Put("4th_test", smallbuf, config.PutOptions{}); err != nil { | ||
t.Fatal(err) | ||
} | ||
}) | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should follow client interface, let's have separate
AlarmList
andAlarmDisarm
calls.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed. thanks.